Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to bright_use_group1=True option in firstrame #9199

Open
stscijgbot-jp opened this issue Feb 18, 2025 · 3 comments
Open

Change to bright_use_group1=True option in firstrame #9199

stscijgbot-jp opened this issue Feb 18, 2025 · 3 comments

Comments

@stscijgbot-jp
Copy link
Collaborator

Issue JP-3888 was created on JIRA by Karl Gordon:

The option bright_use_group1 in the firstframe step is currently set to False. It should be set to True once the appropriate testing by the MIRI team for all modes is completed. This ticket is to motivate the testing and then changing to True for this option. This change will only affect pixels that saturate between the 2nd and 3rd groups that currently have NaN values. Changing this will create measurements for these pixels that are accurate to at least 1% (see report on this topic).

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Assigning to Boris Trahin to coordinate MIRI input.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by David Law on JIRA:

Noting also that once MIRI signs off on this, it should be possible to implement via a param ref file update.

@stscijgbot-jp
Copy link
Collaborator Author

Comment by Karl Gordon on JIRA:

Agreed that this can be updated via a parameter reference file. Note that there currently is no parameter reference file for firstframe, hence one will need to be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant