Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Representation of an empty layer is confusing #3872

Open
kacpersaw opened this issue Dec 17, 2022 · 0 comments
Open

Representation of an empty layer is confusing #3872

kacpersaw opened this issue Dec 17, 2022 · 0 comments

Comments

@kacpersaw
Copy link
Contributor

Description

When I'm streaming layers from node using /spacemesh.v1.MeshService/LayerStream, sometimes I'm getting hash
0xe3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 which is repeated for a different layers.

number:{number:12860}  hash:"\xe3\xb0\xc4B\x98\xfc\x1c\x14\x9a\xfb\xf4șo\xb9$'\xaeA\xe4d\x9b\x93L\xa4\x95\x99\x1bxR\xb8U"  root_state_hash:"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"
LAYER_STATUS_UNSPECIFIED

But in other cases hash is empty and it's built from 0s. (0x0000000000000000000000000000000000000000000000000000000000000000)

number:{number:12909}  hash:"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"  root_state_hash:"\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"
LAYER_STATUS_UNSPECIFIED

I find it confusing and not friendly. I think it would be nice to get this standardised and documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants