Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Followup to PR #1120] Bulk ban maximum limit isn't configurable #1122

Open
TheArcaneBrony opened this issue Jun 8, 2024 · 1 comment
Open

[Followup to PR #1120] Bulk ban maximum limit isn't configurable #1122

TheArcaneBrony opened this issue Jun 8, 2024 · 1 comment
Labels
Enhancement New feature or request Good first issue Module: API Priority:low Minor inconvenience, doesn't break Spacebar

Comments

@TheArcaneBrony
Copy link
Member

Pull request #1120 implemented the bulk ban endpoint.

https://github.com/spacebarchat/server/pull/1120/files#diff-520e2810e59768a3c50716eae8d489c6ade061231c77858d89732fb9c372cf8cR54-R59

This implementation has the bulk ban limit hardcoded as 200 members.
It would be nice if this could be configured.
@TheArcaneBrony TheArcaneBrony added Enhancement New feature or request Module: API Good first issue Priority:low Minor inconvenience, doesn't break Spacebar labels Jun 8, 2024
aintDatCap pushed a commit to aintDatCap/spacebar-server that referenced this issue Jul 24, 2024
Implemented proposal described in the issue spacebarchat#1122
5a20924
@aintDatCap
Copy link

This issue should probably be closed (pr. #1153)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request Good first issue Module: API Priority:low Minor inconvenience, doesn't break Spacebar
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheArcaneBrony @aintDatCap