Merge branch 'release/v8.35'

Author: love-linger

README.md

@@ -81,7 +81,6 @@ For **macOS** users:
 * Make sure your mac trusts all software from anywhere. For more information, search `spctl --master-disable`.
 * Make sure [git-credential-manager](https://github.com/git-ecosystem/git-credential-manager/releases) is installed on your mac.
 * You may need to run `sudo xattr -cr /Applications/SourceGit.app` to make sure the software works.
-* You may need to start this app from commandline by using `open -a SourceGit` to introduce the `PATH` environment variable from your shell.
 
 For **Linux** users:
 

VERSION

@@ -1 +1 @@
-8.34
+8.35

screenshots/theme_dark.png

@@ -5,27 +5,27 @@ namespace SourceGit.Commands
 {
     public class Add : Command
     {
-        public Add(string repo, List<Models.Change> changes = null)
+        public Add(string repo, bool includeUntracked)
+        {
+            WorkingDirectory = repo;
+            Context = repo;
+            Args = includeUntracked ? "add ." : "add -u .";
+        }
+        
+        public Add(string repo, List<Models.Change> changes)
         {
             WorkingDirectory = repo;
             Context = repo;
 
-            if (changes == null || changes.Count == 0)
-            {
-                Args = "add .";
-            }
-            else
+            var builder = new StringBuilder();
+            builder.Append("add --");
+            foreach (var c in changes)
             {
-                var builder = new StringBuilder();
-                builder.Append("add --");
-                foreach (var c in changes)
-                {
-                    builder.Append(" \"");
-                    builder.Append(c.Path);
-                    builder.Append("\"");
-                }
-                Args = builder.ToString();
+                builder.Append(" \"");
+                builder.Append(c.Path);
+                builder.Append("\"");
             }
+            Args = builder.ToString();
         }
     }
 }

screenshots/theme_light.png

@@ -2,12 +2,19 @@
 {
     public class CherryPick : Command
     {
-        public CherryPick(string repo, string commits, bool noCommit)
+        public CherryPick(string repo, string commits, bool noCommit, bool appendSourceToMessage, string extraParams)
         {
-            var mode = noCommit ? "-n" : "--ff";
             WorkingDirectory = repo;
             Context = repo;
-            Args = $"cherry-pick {mode} {commits}";
+
+            Args = "cherry-pick ";
+            if (noCommit)
+                Args += "-n ";
+            if (appendSourceToMessage)
+                Args += "-x ";
+            if (!string.IsNullOrEmpty(extraParams))
+                Args += $"{extraParams} ";
+            Args += commits;
         }
     }
 }

src/Commands/Add.cs

@@ -195,15 +195,6 @@ private ProcessStartInfo CreateGitStartInfo()
             if (OperatingSystem.IsLinux())
                 start.Environment.Add("LANG", "en_US.UTF-8");
 
-            // Fix sometimes `LSEnvironment` not working on macOS
-            if (OperatingSystem.IsMacOS())
-            {
-                if (start.Environment.TryGetValue("PATH", out var path))
-                    start.Environment.Add("PATH", $"/opt/homebrew/bin:/opt/homebrew/sbin:{path}");
-                else
-                    start.Environment.Add("PATH", "/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin");
-            }
-
             // Force using this app as git editor.
             switch (Editor)
             {

src/Commands/CherryPick.cs

@@ -24,9 +24,9 @@ public Diff(string repo, Models.DiffOption opt, int unified, bool ignoreWhitespa
             Context = repo;
 
             if (ignoreWhitespace)
-                Args = $"diff --ignore-cr-at-eol --ignore-all-space --unified={unified} {opt}";
+                Args = $"diff --patch --ignore-cr-at-eol --ignore-all-space --unified={unified} {opt}";
             else
-                Args = $"diff --ignore-cr-at-eol --unified={unified} {opt}";
+                Args = $"diff --patch --ignore-cr-at-eol --unified={unified} {opt}";
         }
 
         public Models.DiffResult Result()

src/Commands/Command.cs

@@ -10,7 +10,7 @@ public GC(string repo, Action<string> outputHandler)
             WorkingDirectory = repo;
             Context = repo;
             TraitErrorAsOutput = true;
-            Args = "gc --prune";
+            Args = "gc --prune=now";
         }
 
         protected override void OnReadline(string line)

src/Commands/Diff.cs

@@ -14,7 +14,7 @@ public QueryBranches(string repo)
         {
             WorkingDirectory = repo;
             Context = repo;
-            Args = "branch -l --all -v --format=\"%(refname)$%(objectname)$%(HEAD)$%(upstream)$%(upstream:trackshort)\"";
+            Args = "branch -l --all -v --format=\"%(refname)%00%(objectname)%00%(HEAD)%00%(upstream)%00%(upstream:trackshort)\"";
         }
 
         public List<Models.Branch> Result()
@@ -37,7 +37,7 @@ public QueryBranches(string repo)
 
         private Models.Branch ParseLine(string line)
         {
-            var parts = line.Split('$');
+            var parts = line.Split('\0');
             if (parts.Length != 5)
                 return null;