Change some game redirects to LumiNUS, Piazza (#292)

* Fix dead links in game, refactor most links as constants

* Bump version (v0.1.8 -> v1.0.0)

* Make LINKS an enum

Author: ning-y

package.json

@@ -1,7 +1,7 @@
 {
   "private": true,
   "name": "cadet-frontend",
-  "version": "0.1.8",
+  "version": "1.0.0",
   "scripts-info": {
     "format": "Format source code",
     "start": "Start the Webpack development server",

src/components/NavigationBar.tsx

@@ -11,12 +11,9 @@ import * as React from 'react'
 import { NavLink } from 'react-router-dom'
 
 import { Role } from '../reducers/states'
+import { LINKS } from '../utils/constants'
 import Dropdown from './dropdown'
 
-const LUMINUS_LINK = 'https://luminus.nus.edu.sg/modules/8722e9a5-abc5-4160-820d-bf69d8a63c6f'
-
-const PIAZZA_LINK = 'https://piazza.com/nus.edu.sg/fall2018/cs1101s'
-
 export interface INavigationBarProps {
   handleLogOut: () => void
   role?: Role
@@ -40,7 +37,7 @@ const NavigationBar: React.SFC<INavigationBarProps> = props => (
         activeClassName="pt-active"
         className="NavigationBar__link pt-button pt-minimal"
         target="_blank"
-        to={LUMINUS_LINK}
+        to={LINKS.LUMINUS}
       >
         <Icon icon={IconNames.BOOK} />
         <div className="navbar-button-text hidden-xs">News &amp; Material</div>
@@ -50,7 +47,7 @@ const NavigationBar: React.SFC<INavigationBarProps> = props => (
         activeClassName="pt-active"
         className="NavigationBar__link pt-button pt-minimal"
         target="_blank"
-        to={PIAZZA_LINK}
+        to={LINKS.PIAZZA}
       >
         <Icon icon={IconNames.CHAT} />
         <div className="navbar-button-text hidden-xs">Forum</div>

src/components/Playground.tsx

@@ -4,14 +4,13 @@ import { HotKeys } from 'react-hotkeys'
 import { RouteComponentProps } from 'react-router'
 
 import { InterpreterOutput } from '../reducers/states'
+import { LINKS } from '../utils/constants'
 import { ExternalLibraryName } from './assessment/assessmentShape'
 import Markdown from './commons/Markdown'
 import Workspace, { WorkspaceProps } from './workspace'
 import { SideContentTab } from './workspace/side-content'
 import ListVisualizer from './workspace/side-content/ListVisualizer'
 
-const SICP_SITE = 'https://www.comp.nus.edu.sg/~cs1101s/source/'
-
 const CHAP = '\xa7'
 
 const INTRODUCTION = `
@@ -21,8 +20,8 @@ The language _Source_ is the official language of the textbook _Structure and
 Interpretation of Computer Programs, JavaScript Adaptation_. You have never
 heard of Source? No worries! It was invented just for the purpose of the book.
 Source is a sublanguage of ECMAScript 2016 (7th Edition) and defined in [the
-documents titled _"Source ${CHAP}x"_](${SICP_SITE}), where x refers to the
-respective textbook chapter. For example, Source ${CHAP}3 is suitable for
+documents titled _"Source ${CHAP}x"_](${LINKS.SOURCE_DOCS}), where x refers to
+the respective textbook chapter. For example, Source ${CHAP}3 is suitable for
 textbook Chapter 3 and the preceeding chapters.
 
 The playground comes with an editor and a REPL, on the left and right of the

src/components/academy/game/create-initializer.js

@@ -1,3 +1,4 @@
+import { LINKS } from '../../../utils/constants'
 import { history } from '../../../utils/history'
 
 export default function (StoryXMLPlayer, story, username, attemptedAll) {
@@ -20,21 +21,21 @@ export default function (StoryXMLPlayer, story, username, attemptedAll) {
     openTemplate: function (name) {
       switch (name) {
         case 'textbook':
-          return window.open('https://www.comp.nus.edu.sg/~cs1101s/sicp/', '_blank');
+          return window.open(LINKS.TEXTBOOK, '_blank');
         case 'announcements':
-          return history.push('/news');
+          return history.push(LINKS.LUMINUS);
         case 'lesson_plan':
           return history.push('/academy/missions');
         case 'students':
-          return history.push('/news');
+          return history.push(LINKS.PIAZZA);
         case 'materials':
-          return history.push('/material');
+          return history.push(LINKS.LUMINUS);
         case 'IDE':
           return history.push('/playground');
         case 'path':
           return history.push('/academy/paths');
         default:
-          return history.push('/news');
+          return history.push(LINKS.LUMINUS);
       }
     },
     pickUpCollectible: function () { },

src/components/dropdown/About.tsx

@@ -2,6 +2,8 @@ import { Classes, Dialog, Tab, Tabs } from '@blueprintjs/core'
 import { IconNames } from '@blueprintjs/icons'
 import * as React from 'react'
 
+import { LINKS } from '../../utils/constants'
+
 type DialogProps = {
   isOpen: boolean
   onClose: () => void
@@ -38,7 +40,7 @@ const panelAbout = (
     <p>
       This iteration of Source Academy, code-named <i>Cadet</i>, is available under the MIT License.
       You may find the source code for Cadet at our GitHub organisation,{' '}
-      <a href="https://github.com/source-academy">Source Academy</a>.
+      <a href={LINKS.GITHUB_ORG}>Source Academy</a>.
     </p>
   </>
 )

src/components/dropdown/Help.tsx

@@ -2,6 +2,8 @@ import { Classes, Dialog } from '@blueprintjs/core'
 import { IconNames } from '@blueprintjs/icons'
 import * as React from 'react'
 
+import { LINKS } from '../../utils/constants'
+
 type DialogProps = {
   isOpen: boolean
   onClose: () => void
@@ -22,17 +24,16 @@ const Help: React.SFC<DialogProps> = props => (
         <li>
           For critical technical issues that seriously affect your learning experience, email the
           Technical Services of the NUS School of Computing at{' '}
-          <a href="mailto:[email protected]">[email protected]</a> or call 6516 2736.
+          <a href={LINKS.TECH_SVC}>[email protected]</a> or call 6516 2736.
         </li>
         <li>
           For non-critical technical issues, such as enhancement suggestions, please use the issue
-          system of the{' '}
-          <a href="https://github.com/source-academy">Source Academy repositories on GitHub</a>.
+          system of the <a href={LINKS.GITHUB_ISSUES}>Source Academy repositories on GitHub</a>.
         </li>
         <li>
           For issues related to the content of missions, quests, paths and contests, use the
-          respective forum at <a href="https://piazza.com/nus.edu.sg/fall2018/cs1101s"> piazza</a>,{' '}
-          or approach your Avenger, Reflection instructor or lecturer.
+          respective forum at <a href={LINKS.PIAZZA}> piazza</a>, or approach your Avenger,
+          Reflection instructor or lecturer.
         </li>
       </ul>
     </div>

src/index.tsx

@@ -5,7 +5,7 @@ import { ConnectedRouter } from 'react-router-redux'
 
 import ApplicationContainer from './containers/ApplicationContainer'
 import { store } from './createStore'
-import { VERSION } from './utils/constants'
+import { LINKS, VERSION } from './utils/constants'
 import { history } from './utils/history'
 import registerServiceWorker from './utils/registerServiceWorker'
 
@@ -16,7 +16,7 @@ const rootContainer = document.getElementById('root') as HTMLElement
 // tslint:disable-next-line
 console.log(
   `%c Source Academy v${VERSION}; ` +
-    'Please visit https://github.com/source-academy/cadet-frontend/issues to report bugs or issues.',
+    `Please visit ${LINKS.GITHUB_ISSUES} to report bugs or issues.`,
   'font-weight: bold;'
 )
 

src/utils/constants.ts

@@ -11,3 +11,13 @@ export const IVLE_KEY = process.env.REACT_APP_IVLE_KEY
 export const VERSION = process.env.REACT_APP_VERSION
 export const BACKEND_URL = process.env.REACT_APP_BACKEND_URL
 export const USE_BACKEND = process.env.REACT_APP_USE_BACKEND
+
+export enum LINKS {
+  GITHUB_ISSUES = 'https://github.com/source-academy/cadet-frontend/issues',
+  GITHUB_ORG = 'https://github.com/source-academy',
+  LUMINUS = 'https://luminus.nus.edu.sg/modules/8722e9a5-abc5-4160-820d-bf69d8a63c6f',
+  PIAZZA = 'https://piazza.com/nus.edu.sg/fall2018/cs1101s',
+  SOURCE_DOCS = 'https://www.comp.nus.edu.sg/~cs1101s/source/',
+  TECH_SVC = 'mailto:[email protected]',
+  TEXTBOOK = 'https://www.comp.nus.edu.sg/~cs1101s/sicp/'
+}