Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted output in tests (and probably outside of it, too) #392

Open
PhilippWendler opened this issue Sep 13, 2024 · 1 comment
Open

Unwanted output in tests (and probably outside of it, too) #392

PhilippWendler opened this issue Sep 13, 2024 · 1 comment

Comments

@PhilippWendler
Copy link
Member

When running tests, such as in this case, some of the tests seem to print warnings like the following:

  • Unexpected logic for quantifier elimination ALL
  • WARNING: optimization with quantified constraints is not supported

I am not sure how to interpret this, does this indicate a bug?

Anyway, given that these strings do not appear in the source of JavaSMT, I assume that this outputs will also appear in certain situations during regular usage of JavaSMT (outside of tests). However, JavaSMT and the solvers are libraries, they should never write to stdout or stderr unless explicitly told so by the calling application. Any output is likely to mess up the desired output of the application. Libraries should use logging, or, if the message indicate bugs, communicate this via exceptions.

@kfriedberger
Copy link
Member

kfriedberger commented Sep 13, 2024

I fully agree with you. Libraries should not print directly to stdout/stderr.
There have been cases in the past, where we informed the developers and they changed their solver code accordingly.
Someone could collect the solvers with messages and report them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants