Skip to content

Help pages need updating to mention that mp3s are now valid samples #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ethancrawford opened this issue May 10, 2025 · 0 comments · May be fixed by #3459
Open

Help pages need updating to mention that mp3s are now valid samples #3458

ethancrawford opened this issue May 10, 2025 · 0 comments · May be fixed by #3459
Labels
docs

Comments

@ethancrawford
Copy link
Collaborator

ethancrawford commented May 10, 2025 •
edited
Loading

The change in a7f8965 to allow mp3s as valid samples should also be reflected in the relevant parts of the documentation, such as:

sonic-pi/app/server/ruby/lib/sonicpi/lang/sound.rb

Line 2531 in 32cdbcb

doc: "Play back a recorded sound file (sample). Sonic Pi comes with lots of great samples included (see the section under help) but you can also load and play `.wav`, `.wave`, `.aif`, `.aiff`, `.ogg`, `.oga` or `.flac` files from anywhere on your computer too. To play a built-in sample use the corresponding keyword such as `sample :bd_haus`. To play any file on your computer use a full path such as `sample \"/path/to/sample.wav\"`.

(as well as lines 2117, 2135, 2165, 2281, 2751, and 3455 of the same file), and

sonic-pi/etc/doc/tutorial/03.6-External-Samples.md

Line 28 in 32cdbcb

So how do you play any arbitrary WAV, AIFF, OGG, OGA or FLAC file on your computer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs to mention that mp3s are supported. emlyn/sonic-pi
1 participant
@ethancrawford