Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and update Jekyll layouts, gems and themes #166

Open
1 of 3 tasks
sondr3 opened this issue Feb 16, 2018 · 5 comments
Open
1 of 3 tasks

Upgrade and update Jekyll layouts, gems and themes #166

sondr3 opened this issue Feb 16, 2018 · 5 comments

Comments

@sondr3
Copy link
Owner

sondr3 commented Feb 16, 2018

  • Figure out how the new themeing works now that the default theme is it's own gem
  • Update the gems that was installed in the previous versions
  • Figure out a better/alternate way of injecting CSS and JS into pages because the current way is really error prone and super brittle. Nor is it very reliable, I don't like it one bit.
@sondr3 sondr3 added this to the 2.0 milestone Feb 16, 2018
@ghost
Copy link

ghost commented Feb 19, 2018

From what I understand, a lot of new theme directories and files are stored in the gem. To overwrite them, you move them to the root of the project or make new copies in the root of the project.

So I think if we download a new version and include all the dirs and files in the jekyll generator we should be good to go. Is this the way you updated it yesterday?

@sondr3
Copy link
Owner Author

sondr3 commented Feb 19, 2018

Yeah, I downloaded the latest version of minima and copied the files into the app, I did do some changes to the paths of the SCSS and such, and that’s so that we can integrate build tools properly. Otherwise it’s a straight default install of Jekyll.

I think the next step is getting the prompts back again to fill out _config.yml with site name, author information and such. In the last version of this generator I also had to have two separate config files for Jekyll, we should look into if we could just use one single config file instead. We also need to figure out a good way to prompt for social media, where the user can select which services (if any) they want to fill and add to the footer. Other than that I’m looking at webpack right now, I added some comments in #168 about it.

@ghost
Copy link

ghost commented Feb 20, 2018

In regards to the first check box, layout directories and files can be moved to the root of the project to override gem theme or you can create new _layouts, etc. at the project root. Jekyll looks at project root first and then to the gem. Obviously naming conventions are important, but it should be as simple as that!

@sondr3
Copy link
Owner Author

sondr3 commented Feb 20, 2018

I saw that in the documentation, my only thought was that for a lot of people they will download this generator so that they can create their own CSS and such with Jekyll and therefore including the whole theme instead of just overriding a few of them would work best. Mostly because it would allow people to quickly iterate with changing the layout instead of having to go to Github and check out how minima does it.

@ghost
Copy link

ghost commented Feb 20, 2018

I'll look into prompts for the _config.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant