Add ERB lint checks using erb-formatter

Author: elia

.circleci/config.yml

@@ -234,9 +234,17 @@ jobs:
       - checkout
       - run: 'bundle install'
       - run:
-          name: Check with rubocop
+          name: Check Ruby
           command: |
             bundle exec rubocop --parallel --format junit --out "$PWD/test-results/rubocop-results.xml" --format progress
+      - run:
+          name: Check ERB
+          command: |
+            # enable recursive globbing with "**"
+            shopt -s globstar
+
+            # we're only interested in errors
+            bundle exec erb-format **/*.html.erb > /dev/null
       - run:
           name: Check JavaScript
           command: |

.format-erb-ignore

@@ -0,0 +1,6 @@
+sandbox/**
+tmp/**
+**/generators/**
+
+# this file is using tail `if` checks which are not supported by erb-formatter
+backend/app/views/spree/admin/shared/_product_tabs.html.erb

Gemfile

@@ -54,6 +54,7 @@ group :admin do
 end
 
 group :utils do
+  gem 'erb-formatter', require: false
   gem 'pry'
   gem 'launchy', require: false
   gem 'rubocop', '~> 1', require: false

admin/app/components/solidus_admin/ui/table/component.html.erb

@@ -103,7 +103,7 @@
               content_tag(:span, "0", "data-#{stimulus_id}-target": "selectedRowsCount"),
               " #{t('.rows_selected')}.",
             ])), colspan: @columns.count - 1) %>
-          </div>
+          </tr>
         </thead>
       <% end %>
 

backend/app/views/spree/admin/images/_image_row.html.erb

@@ -13,11 +13,7 @@
       "spree/admin/shared/modal",
       target: "modal-image-#{image.id}",
       title: image.alt,
-      content: %{
-        <div class='align-center'>
-          #{image_tag(image.url(:large))}
-        </div>
-      }.html_safe
+      content: tag.div(image_tag(image.url(:large)), class: 'align-center')
     ) %>
   </td>
 

core/app/views/spree/order_mailer/inventory_cancellation_email.html.erb

@@ -19,7 +19,7 @@
           </tr>
         <% end %>
       </table>
-      <p>
+      <p></p>
     </td>
     <td class="expander"></td>
   </tr>