Skip to content

Commit 4112d34

Browse files
committed
Fix test order and use default image if env is not set
1 parent d5dee4f commit 4112d34

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Diff for: Makefile

-2
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ push-release:
3232

3333
e2e:
3434
@BOOKSTACK_IMAGE="$(DOCKER_RELEASE_REG)/${DOCKER_IMAGE_DEV}:${DOCKER_INTERNAL_TAG}" docker-compose -f docker-compose.test.yml up -d
35-
@echo "Wait 30 seconds to spinn up everything"
36-
@sleep 30
3735
@BOOKSTACK_IMAGE="$(DOCKER_RELEASE_REG)/${DOCKER_IMAGE_DEV}:${DOCKER_INTERNAL_TAG}" docker-compose -f docker-compose.test.yml run --rm sut
3836
@BOOKSTACK_IMAGE="$(DOCKER_RELEASE_REG)/${DOCKER_IMAGE_DEV}:${DOCKER_INTERNAL_TAG}" docker-compose -f docker-compose.test.yml down -v
3937

Diff for: docker-compose.test.yml

+3-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ services:
33
sut:
44
image: appropriate/curl
55
command: ["--retry", "15","--retry-delay","5","--retry-connrefused","http://bookstack/login"]
6+
depends_on:
7+
- bookstack
68
mysql:
79
image: mysql:5.7.21
810
environment:
@@ -14,8 +16,7 @@ services:
1416
- mysql-data:/var/lib/mysql
1517

1618
bookstack:
17-
container_name: bookstack
18-
image: ${BOOKSTACK_IMAGE}
19+
image: ${BOOKSTACK_IMAGE:-solidnerd/bookstack}
1920
depends_on:
2021
- mysql
2122
environment:

0 commit comments

Comments
 (0)