chore: ci 스크립트 작성 및 ci 통과를 위한 코드 수정 (#266)

nayonsoso · web-flow · commit 6dfc6ed7ebd3 · 2025-04-02T16:49:52.000+09:00
* chore: ci 스크립트 작성

* chore: 테스트용 application.yml 분리

* test: test profile 제거

* refactor: 애플 시크릿키를 yml로 이동

* refactor: 함수 이름 변경

* refactor: 오타 수정

* refactor: redis testcontainers 설정 수정

* refactor: ddl-auto 옵션 변경

- create-drop을 create로 변경
- 테스트 컨테이너를 실행해서 테스트하기 때문에, 테스트가 종료되면 당연히 테이블이 삭제된다. 따라서 create-drop을 하는것과 create를 하는 것이 동일하게 동작한다. 굳이 create로 바꾼 것은 삭제 시 FK 위반으로 WARN 로그가 불필요하게 백몇줄이 찍히는걸 막기 위해서.

* test: e2e 테스트 수정

- 깨지는 테스트 수정
- 비지니스 로직 변경으로 더 이상 해당되지 않는 테스트 삭제

* chore: createAt과 updateAt의 나노초 길이 고정

* style: 주석 추가

* refactor: MySQL 테스트 컨테이너 설정 변경

- redis 테스트 컨테이너와 동일하게 설정하여 불필요한 인지 부하를 줄인다.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -0,0 +1,37 @@
+name: CI with Gradle
+
+on:
+  pull_request:
+    branches: [ "develop", "release", "master" ]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      checks: write
+
+    steps:
+      - name: Checkout the code
+        uses: actions/checkout@v4
+
+      - name: Set up JDK 17
+        uses: actions/setup-java@v4
+        with:
+          java-version: '17'
+          distribution: 'temurin'
+
+      - name: Setup Gradle
+        uses: gradle/actions/setup-gradle@v4
+
+      - name: Make Gradle wrapper executable
+        run: chmod +x ./gradlew
+
+      - name: Build with Gradle Wrapper
+        run: ./gradlew build
+
+      - name: Publish Test Report
+        uses: mikepenz/action-junit-report@v5
+        if: success() || failure()
+        with:
+          report_paths: '**/build/test-results/test/TEST-*.xml'
diff --git a/src/main/java/com/example/solidconnection/auth/client/AppleOAuthClientSecretProvider.java b/src/main/java/com/example/solidconnection/auth/client/AppleOAuthClientSecretProvider.java
@@ -9,20 +9,17 @@
 import org.apache.tomcat.util.codec.binary.Base64;
 import org.springframework.stereotype.Component;
 
-import java.io.BufferedReader;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.nio.charset.StandardCharsets;
 import java.security.KeyFactory;
+import java.security.NoSuchAlgorithmException;
 import java.security.PrivateKey;
+import java.security.spec.InvalidKeySpecException;
 import java.security.spec.PKCS8EncodedKeySpec;
 import java.util.Date;
-import java.util.stream.Collectors;
 
 import static com.example.solidconnection.custom.exception.ErrorCode.FAILED_TO_READ_APPLE_PRIVATE_KEY;
 
 /*
- * 애플 OAuth 에 필요하 클라이언트 시크릿은 매번 동적으로 생성해야 한다.
+ * 애플 OAuth 에 필요한 클라이언트 시크릿은 매번 동적으로 생성해야 한다.
  * 클라이언트 시크릿은 애플 개발자 계정에서 발급받은 개인키(*.p8)를 사용하여 JWT 를 생성한다.
  * https://developer.apple.com/documentation/accountorganizationaldatasharing/creating-a-client-secret
  * */
@@ -32,14 +29,13 @@ public class AppleOAuthClientSecretProvider {
 
     private static final String KEY_ID_HEADER = "kid";
     private static final long TOKEN_DURATION = 1000 * 60 * 10; // 10min
-    private static final String SECRET_KEY_PATH = "secret/AppleOAuthKey.p8";
 
     private final AppleOAuthClientProperties appleOAuthClientProperties;
     private PrivateKey privateKey;
 
     @PostConstruct
     private void initPrivateKey() {
-        privateKey = readPrivateKey();
+        privateKey = loadPrivateKey();
     }
 
     public String generateClientSecret() {
@@ -57,16 +53,14 @@ public String generateClientSecret() {
                 .compact();
     }
 
-    private PrivateKey readPrivateKey() {
-        try (InputStream is = getClass().getClassLoader().getResourceAsStream(SECRET_KEY_PATH);
-             BufferedReader reader = new BufferedReader(new InputStreamReader(is, StandardCharsets.UTF_8))) {
-
-            String secretKey = reader.lines().collect(Collectors.joining("\n"));
+    private PrivateKey loadPrivateKey() {
+        try {
+            String secretKey = appleOAuthClientProperties.secretKey();
             byte[] encoded = Base64.decodeBase64(secretKey);
             PKCS8EncodedKeySpec keySpec = new PKCS8EncodedKeySpec(encoded);
             KeyFactory keyFactory = KeyFactory.getInstance("EC");
             return keyFactory.generatePrivate(keySpec);
-        } catch (Exception e) {
+        } catch (NoSuchAlgorithmException | InvalidKeySpecException e) {
             throw new CustomException(FAILED_TO_READ_APPLE_PRIVATE_KEY);
         }
     }
diff --git a/src/main/java/com/example/solidconnection/config/client/AppleOAuthClientProperties.java b/src/main/java/com/example/solidconnection/config/client/AppleOAuthClientProperties.java
@@ -10,6 +10,7 @@ public record AppleOAuthClientProperties(
         String publicKeyUrl,
         String clientId,
         String teamId,
-        String keyId
+        String keyId,
+        String secretKey
 ) {
 }
diff --git a/src/main/java/com/example/solidconnection/entity/common/BaseEntity.java b/src/main/java/com/example/solidconnection/entity/common/BaseEntity.java
@@ -9,9 +9,11 @@
 import org.hibernate.annotations.DynamicUpdate;
 import org.springframework.data.jpa.domain.support.AuditingEntityListener;
 
-import java.time.ZoneId;
 import java.time.ZonedDateTime;
 
+import static java.time.ZoneOffset.UTC;
+import static java.time.temporal.ChronoUnit.MICROS;
+
 @MappedSuperclass
 @EntityListeners(AuditingEntityListener.class)
 @Getter
@@ -24,12 +26,12 @@ public abstract class BaseEntity {
 
     @PrePersist
     public void onPrePersist() {
-        this.createdAt = ZonedDateTime.now(ZoneId.of("UTC"));
+        this.createdAt = ZonedDateTime.now(UTC).truncatedTo(MICROS); // 나노초 6자리 까지만 저장
         this.updatedAt = this.createdAt;
     }
 
     @PreUpdate
     public void onPreUpdate() {
-        this.updatedAt = ZonedDateTime.now(ZoneId.of("UTC"));
+        this.updatedAt = ZonedDateTime.now(UTC).truncatedTo(MICROS);
     }
 }
diff --git a/src/test/java/com/example/solidconnection/database/DatabaseConnectionTest.java b/src/test/java/com/example/solidconnection/database/DatabaseConnectionTest.java
@@ -8,7 +8,6 @@
 import org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase;
 import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
 import org.springframework.jdbc.core.JdbcTemplate;
-import org.springframework.test.context.ActiveProfiles;
 
 import java.sql.DatabaseMetaData;
 import java.sql.SQLException;
@@ -20,7 +19,6 @@
 
 @Disabled
 @AutoConfigureTestDatabase(connection = EmbeddedDatabaseConnection.H2, replace = AutoConfigureTestDatabase.Replace.ANY)
-@ActiveProfiles("test")
 @DataJpaTest
 class DatabaseConnectionTest {
 
diff --git a/src/test/java/com/example/solidconnection/database/RedisConnectionTest.java b/src/test/java/com/example/solidconnection/database/RedisConnectionTest.java
@@ -6,12 +6,10 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.data.redis.core.RedisTemplate;
-import org.springframework.test.context.ActiveProfiles;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 @Disabled
-@ActiveProfiles("test")
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
 class RedisConnectionTest {
 
diff --git a/src/test/java/com/example/solidconnection/e2e/ApplicantsQueryTest.java b/src/test/java/com/example/solidconnection/e2e/ApplicantsQueryTest.java
@@ -105,7 +105,7 @@ public void setUpUserAndToken() {
         ApplicationsResponse response = RestAssured.given().log().all()
                 .header("Authorization", "Bearer " + accessToken)
                 .when().log().all()
-                .get("/applications")
+                .get("/applications/competitors")
                 .then().log().all()
                 .statusCode(200)
                 .extract().as(ApplicationsResponse.class);
@@ -119,30 +119,24 @@ public void setUpUserAndToken() {
                         List.of(ApplicantResponse.of(사용자1_지원정보, false))),
                 UniversityApplicantsResponse.of(괌대학_B_지원_정보,
                         List.of(ApplicantResponse.of(나의_지원정보, true))),
-                UniversityApplicantsResponse.of(메이지대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자2_지원정보, false))),
-                UniversityApplicantsResponse.of(네바다주립대학_라스베이거스_지원_정보,
-                        List.of(ApplicantResponse.of(사용자3_지원정보, false)))
+                UniversityApplicantsResponse.of(린츠_카톨릭대학_지원_정보,
+                        List.of())
         ));
         assertThat(secondChoiceApplicants).containsAnyElementsOf(List.of(
                 UniversityApplicantsResponse.of(괌대학_A_지원_정보,
-                        List.of(ApplicantResponse.of(나의_지원정보, true))),
+                        List.of(ApplicantResponse.of(나의_지원정보, false))),
                 UniversityApplicantsResponse.of(괌대학_B_지원_정보,
-                        List.of(ApplicantResponse.of(사용자1_지원정보, false))),
-                UniversityApplicantsResponse.of(메이지대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자3_지원정보, false))),
-                UniversityApplicantsResponse.of(그라츠대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자2_지원정보, false)))
+                        List.of(ApplicantResponse.of(사용자1_지원정보, true))),
+                UniversityApplicantsResponse.of(린츠_카톨릭대학_지원_정보,
+                        List.of())
         ));
         assertThat(thirdChoiceApplicants).containsAnyElementsOf(List.of(
+                UniversityApplicantsResponse.of(괌대학_A_지원_정보,
+                        List.of()),
+                UniversityApplicantsResponse.of(괌대학_B_지원_정보,
+                        List.of()),
                 UniversityApplicantsResponse.of(린츠_카톨릭대학_지원_정보,
-                        List.of(ApplicantResponse.of(나의_지원정보, true))),
-                UniversityApplicantsResponse.of(서던덴마크대학교_지원_정보,
-                        List.of(ApplicantResponse.of(사용자2_지원정보, false))),
-                UniversityApplicantsResponse.of(그라츠공과대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자1_지원정보, false))),
-                UniversityApplicantsResponse.of(메이지대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자3_지원정보, false)))
+                        List.of(ApplicantResponse.of(나의_지원정보, true)))
         ));
     }
 
@@ -151,7 +145,7 @@ public void setUpUserAndToken() {
         ApplicationsResponse response = RestAssured.given().log().all()
                 .header("Authorization", "Bearer " + accessToken)
                 .when().log().all()
-                .get("/applications?region=" + 영미권.getCode())
+                .get("/applications/competitors?region=" + 영미권.getCode())
                 .then().log().all()
                 .statusCode(200)
                 .extract().as(ApplicationsResponse.class);
@@ -163,68 +157,22 @@ public void setUpUserAndToken() {
                 UniversityApplicantsResponse.of(괌대학_A_지원_정보,
                         List.of(ApplicantResponse.of(사용자1_지원정보, false))),
                 UniversityApplicantsResponse.of(괌대학_B_지원_정보,
-                        List.of(ApplicantResponse.of(나의_지원정보, true))),
-                UniversityApplicantsResponse.of(네바다주립대학_라스베이거스_지원_정보,
-                        List.of(ApplicantResponse.of(사용자3_지원정보, false)))));
+                        List.of(ApplicantResponse.of(나의_지원정보, true)))
+        ));
         assertThat(secondChoiceApplicants).containsAnyElementsOf(List.of(
                 UniversityApplicantsResponse.of(괌대학_A_지원_정보,
                         List.of(ApplicantResponse.of(나의_지원정보, true))),
                 UniversityApplicantsResponse.of(괌대학_B_지원_정보,
-                        List.of(ApplicantResponse.of(사용자1_지원정보, false)))));
-    }
-
-    @Test
-    void 대학_국문_이름으로_필터링해서_지원자를_조회한다() {
-        ApplicationsResponse response = RestAssured.given().log().all()
-                .header("Authorization", "Bearer " + accessToken)
-                .when().log().all()
-                .get("/applications?keyword=라")
-                .then().log().all()
-                .statusCode(200)
-                .extract().as(ApplicationsResponse.class);
-
-        List<UniversityApplicantsResponse> firstChoiceApplicants = response.firstChoice();
-        List<UniversityApplicantsResponse> secondChoiceApplicants = response.secondChoice();
-
-        assertThat(firstChoiceApplicants).containsExactlyInAnyOrder(
-                UniversityApplicantsResponse.of(그라츠대학_지원_정보, List.of()),
-                UniversityApplicantsResponse.of(그라츠공과대학_지원_정보, List.of()),
-                UniversityApplicantsResponse.of(네바다주립대학_라스베이거스_지원_정보,
-                        List.of(ApplicantResponse.of(사용자3_지원정보, false))));
-        assertThat(secondChoiceApplicants).containsAnyElementsOf(List.of(
-                UniversityApplicantsResponse.of(그라츠대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자2_지원정보, false))),
-                UniversityApplicantsResponse.of(그라츠공과대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자3_지원정보, false))),
-                UniversityApplicantsResponse.of(네바다주립대학_라스베이거스_지원_정보, List.of())));
-    }
-
-    @Test
-    void 국가_국문_이름으로_필터링해서_지원자를_조회한다() {
-        ApplicationsResponse response = RestAssured.given().log().all()
-                .header("Authorization", "Bearer " + accessToken)
-                .when().log().all()
-                .get("/applications?keyword=일본")
-                .then().log().all()
-                .statusCode(200)
-                .extract().as(ApplicationsResponse.class);
-
-        List<UniversityApplicantsResponse> firstChoiceApplicants = response.firstChoice();
-        List<UniversityApplicantsResponse> secondChoiceApplicants = response.secondChoice();
-
-        assertThat(firstChoiceApplicants).containsExactlyInAnyOrder(
-                UniversityApplicantsResponse.of(메이지대학_지원_정보,
-                        List.of(ApplicantResponse.of(사용자2_지원정보, false))));
-        assertThat(secondChoiceApplicants).containsExactlyInAnyOrder(
-                UniversityApplicantsResponse.of(메이지대학_지원_정보, List.of()));
+                        List.of(ApplicantResponse.of(사용자1_지원정보, false)))
+        ));
     }
 
     @Test
     void 지원자를_조회할_때_이전학기_지원자는_조회되지_않는다() {
         ApplicationsResponse response = RestAssured.given().log().all()
                 .header("Authorization", "Bearer " + accessToken)
                 .when().log().all()
-                .get("/applications")
+                .get("/applications/competitors")
                 .then().log().all()
                 .statusCode(200)
                 .extract().as(ApplicationsResponse.class);
diff --git a/src/test/java/com/example/solidconnection/support/DatabaseCleaner.java b/src/test/java/com/example/solidconnection/support/DatabaseCleaner.java
@@ -5,13 +5,11 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.data.redis.core.RedisTemplate;
 import org.springframework.stereotype.Component;
-import org.springframework.test.context.ActiveProfiles;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 import java.util.Objects;
 
-@ActiveProfiles("test")
 @Component
 public class DatabaseCleaner {
 
diff --git a/src/test/java/com/example/solidconnection/support/MySQLTestContainer.java b/src/test/java/com/example/solidconnection/support/MySQLTestContainer.java
@@ -1,34 +1,24 @@
 package com.example.solidconnection.support;
 
-import jakarta.annotation.PostConstruct;
-import org.springframework.boot.jdbc.DataSourceBuilder;
-import org.springframework.boot.test.context.TestConfiguration;
-import org.springframework.context.annotation.Bean;
+import org.springframework.boot.test.util.TestPropertyValues;
+import org.springframework.context.ApplicationContextInitializer;
+import org.springframework.context.ConfigurableApplicationContext;
 import org.testcontainers.containers.MySQLContainer;
-import org.testcontainers.junit.jupiter.Container;
 
-import javax.sql.DataSource;
+public class MySQLTestContainer implements ApplicationContextInitializer<ConfigurableApplicationContext> {
 
-@TestConfiguration
-public class MySQLTestContainer {
-
-    @Container
     private static final MySQLContainer<?> CONTAINER = new MySQLContainer<>("mysql:8.0");
 
-    @Bean
-    public DataSource dataSource() {
-        return DataSourceBuilder.create()
-                .url(CONTAINER.getJdbcUrl())
-                .username(CONTAINER.getUsername())
-                .password(CONTAINER.getPassword())
-                .driverClassName(CONTAINER.getDriverClassName())
-                .build();
+    static {
+        CONTAINER.start();
     }
 
-    @PostConstruct
-    void startContainer() {
-        if (!CONTAINER.isRunning()) {
-            CONTAINER.start();
-        }
+    @Override
+    public void initialize(ConfigurableApplicationContext applicationContext) {
+        TestPropertyValues.of(
+                "spring.datasource.url=" + CONTAINER.getJdbcUrl(),
+                "spring.datasource.username=" + CONTAINER.getUsername(),
+                "spring.datasource.password=" + CONTAINER.getPassword()
+        ).applyTo(applicationContext.getEnvironment());
     }
 }
diff --git a/src/test/java/com/example/solidconnection/support/RedisTestContainer.java b/src/test/java/com/example/solidconnection/support/RedisTestContainer.java
diff --git a/src/test/java/com/example/solidconnection/support/TestContainerDataJpaTest.java b/src/test/java/com/example/solidconnection/support/TestContainerDataJpaTest.java
diff --git a/src/test/java/com/example/solidconnection/support/TestContainerSpringBootTest.java b/src/test/java/com/example/solidconnection/support/TestContainerSpringBootTest.java
diff --git a/src/test/resources/application.yml b/src/test/resources/application.yml

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ public record AppleOAuthClientProperties(`
`10`	`10`	`String publicKeyUrl,`
`11`	`11`	`String clientId,`
`12`	`12`	`String teamId,`
`13`		`- String keyId`
	`13`	`+ String keyId,`
	`14`	`+ String secretKey`
`14`	`15`	`) {`
`15`	`16`	`}`