Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

[single-pool-stake] Remove deprecated functions from cli #6305

Open
samkim-crypto opened this issue Feb 28, 2024 · 2 comments
Open

[single-pool-stake] Remove deprecated functions from cli #6305

samkim-crypto opened this issue Feb 28, 2024 · 2 comments

Comments

@samkim-crypto
Copy link
Contributor

Problem

Solana clap-v3 utils deprecated a number of functions with version 1.18. #6278 temporarily suppresses the warnings from deprecated functions.

Solution

Remove the deprecated functions.

@tonton-sol
Copy link
Contributor

Was going to work on this but it uses Clap Derive not Clap Builder. Is this intentional? Could I convert to builder, and if so should this be in a separate PR?

@samkim-crypto
Copy link
Contributor Author

Thanks so much for the contribution! Clap derive is more readable and therefore, preferable over builder in general, so let's keep it derive for single-pool-stake. I have not checked yet if solana-clap-v3-utils currently has all the tools necessary to remove all the deprecated functions even for clap derive, but if not, then we can add the necessary interface to solana-clap-v3-utils.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants