-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTelemetry attributes to the metrics backend #2292
Comments
/bounty $500 |
💎 $500 bounty • SoftwareMillSteps to solve:
Thank you for contributing to softwaremill/sttp! Add a bounty • Share on socials
|
@adamw I have experience with OTEL and my experience through an internship and contributions to OTEL and Jaeger. I am throwing my hat to crack this
|
(copy-paste from softwaremill/tapir#4057). You can use OpenTelemetry semantic conventions to generate specs and use them in tests to ensure all required attributes are in place. Here are a few examples:
|
@iRevive thanks, this looks interesting. @varshith257 if we could use this somehow to simplify / automate the testing, that would be great |
As we are getting first PRs for the bounties, I've published our "How to prepare a good PR" guide. I should have probably done this right away, sorry! :) |
💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
🎉🎈 @varshith257 has been awarded $500! 🎈🎊 |
Currently the OpenTelemetryMetricsBackend reports a number of metrics, following the naming conventions of OpenTelemetry.
However, we only report raw metric values, without any of the attributes as defined here.
The goal of this issue is to report the metrics along with the required attributes. Optionally, we might include other attributes, if this is feasible and "makes sense".
The abstractions currently present in
OpenTelemetryMetricsBackend
might need updating/extending/refactoring; since this targets version 4 (yet unreleased), there are no compatibility requirements.The text was updated successfully, but these errors were encountered: