resolved code review comments

allmightyspiff · allmightyspiff · commit 3d369169c922 · 2022-11-03T13:41:38.000-05:00
diff --git a/.travis.yml b/.travis.yml
diff --git a/README.md b/README.md
@@ -1,15 +1,10 @@
 # A SoftLayer API PHP client.
 
-[![Build Status](https://travis-ci.org/softlayer/softlayer-api-php-client.svg?branch=master)](https://travis-ci.org/softlayer/softlayer-api-php-client)
+![Build Status](https://github.com/softlayer/softlayer-api-php-client/actions/workflows/test.yml/badge.svg)
 
 ## Warning
 
-```
-The latest version 1.x is not backwards-compatible.
-It is necessary to update scripts to function properly with the new version.
-```
-
-Use [v1.2.0](https://github.com/softlayer/softlayer-api-php-client/releases/tag/v1.2) for older PHP versions. [v2.0.0](https://github.com/softlayer/softlayer-api-php-client/releases/tag/v2.0.0) for php 8.1 or higher.
+Use [v1.2.0](https://github.com/softlayer/softlayer-api-php-client/releases/tag/v1.2) for older PHP versions (php < 8.0) . [v2.0.0](https://github.com/softlayer/softlayer-api-php-client/releases/tag/v2.0.0) for php 8.0 or higher.
 
 [PHP 8.0 removed XMLRPC](https://php.watch/versions/8.0/xmlrpc) as a built in extension. As such, it is no longer required as part of the composer file in this project. The XmlRpcClient still exists here if you need it, but we assume most users are using the SoapClient. If there are any issues with this [Let us know on github](https://github.com/softlayer/softlayer-api-php-client/issues)
 
diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
     "name": "softlayer/softlayer-api-php-client",
     "description": "SoftLayer API PHP client",
     "keywords": ["softlayer"],
-    "homepage": "http://sldn.softlayer.com/article/PHP",
+    "homepage": "https://sldn.softlayer.com/php/",
     "license": "MIT",
     "authors": [
         {
diff --git a/example.php b/example.php
@@ -1,6 +1,6 @@
 <?php
 /**
- * Copyright (c) 2010, SoftLayer Technologies, Inc. All rights reserved.
+ * Copyright (c) 2022, SoftLayer Technologies, Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
diff --git a/src/SoapClient.php b/src/SoapClient.php
@@ -523,7 +523,7 @@ public function getHeaders()
     /**
      * Returns the service name
      * 
-     * @return array
+     * @return string
      */
     public function getServiceName()
     {
@@ -533,7 +533,7 @@ public function getServiceName()
     /**
      * Returns the endpoint URL
      * 
-     * @return array
+     * @return string
      */
     public function getEndpointUrl()
     {
diff --git a/tests/SoapClientTest.php b/tests/SoapClientTest.php
@@ -5,9 +5,6 @@
 use PHPUnit\Framework\TestCase;
 use SoftLayer\SoapClient;
 
-/**
- * @author Javier Spagnoletti <phansys@gmail.com>
- */
 class SoapClientTest extends TestCase
 {
 

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`"name": "softlayer/softlayer-api-php-client",`
`3`	`3`	`"description": "SoftLayer API PHP client",`
`4`	`4`	`"keywords": ["softlayer"],`
`5`		`- "homepage": "http://sldn.softlayer.com/article/PHP",`
	`5`	`+ "homepage": "https://sldn.softlayer.com/php/",`
`6`	`6`	`"license": "MIT",`
`7`	`7`	`"authors": [`
`8`	`8`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`<?php`
`2`	`2`	`/**`
`3`		`- * Copyright (c) 2010, SoftLayer Technologies, Inc. All rights reserved.`
	`3`	`+ * Copyright (c) 2022, SoftLayer Technologies, Inc. All rights reserved.`
`4`	`4`	`*`
`5`	`5`	`* Redistribution and use in source and binary forms, with or without`
`6`	`6`	`* modification, are permitted provided that the following conditions are met:`
Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ public function getHeaders()`
`523`	`523`	`/**`
`524`	`524`	`* Returns the service name`
`525`	`525`	`*`
`526`		`- * @return array`
	`526`	`+ * @return string`
`527`	`527`	`*/`
`528`	`528`	`public function getServiceName()`
`529`	`529`	`{`
`@@ -533,7 +533,7 @@ public function getServiceName()`
`533`	`533`	`/**`
`534`	`534`	`* Returns the endpoint URL`
`535`	`535`	`*`
`536`		`- * @return array`
	`536`	`+ * @return string`
`537`	`537`	`*/`
`538`	`538`	`public function getEndpointUrl()`
`539`	`539`	`{`
Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,6 @@`
`5`	`5`	`use PHPUnit\Framework\TestCase;`
`6`	`6`	`use SoftLayer\SoapClient;`
`7`	`7`
`8`		`-/**`
`9`		`- * @author Javier Spagnoletti <[email protected]>`
`10`		`- */`
`11`	`8`	`class SoapClientTest extends TestCase`
`12`	`9`	`{`
`13`	`10`