Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walkthrough, as_grey option not working, png images have 4 channels #23

Open
sciunto opened this issue May 30, 2015 · 7 comments
Open

Comments

@sciunto
Copy link
Contributor

sciunto commented May 30, 2015

Hi,

I'm preparing a tutorial for my lab on trackpy and going though the walkthrough notebook, I noticed that the png images have 4 channels

from skimage.data import imread
imread('../sample_data/bulk_water/bulk_water_000.png')[0]
array([[146, 125,  54, 255],
       [146, 125,  54, 255],
       [146, 125,  56, 255],
       ..., 
       [140, 120,  55, 255],
       [141, 120,  59, 255],
       [142, 121,  60, 255]], dtype=uint8)

frames = pims.ImageSequence('../sample_data/bulk_water/*.png', as_grey=True)

raises

NotImplementedError: I don't know how to convert an image of shaped (424, 640, 4) to greyscale. Write you own function and pass it using the process_func keyword argument.

I can fix the notebook. Do you prefer to keep the use of as_grey option or show how to write a preprocess function...

Might be worth to illustrate both too. I don't know of the preprocess kwarg is illustrated somewhere.

Best

@sciunto
Copy link
Contributor Author

sciunto commented Jun 14, 2015

I just read the code of pims and I think it's fixed in master.

@cennoreth
Copy link

Still broken in the version I have!

@sciunto
Copy link
Contributor Author

sciunto commented Jul 23, 2015

@cennoreth What's your pims version? master freshly build?

@cennoreth
Copy link

yes, I think so - how do I check?

@sciunto
Copy link
Contributor Author

sciunto commented Jul 24, 2015

If it's correctly done in pims, this should tell you if you use the git version or a released version.

python -c 'import pims; print(pims.__version__)'

@sciunto
Copy link
Contributor Author

sciunto commented Jul 24, 2015

I'm with 0.2.2 and it doesn't work, but the implementation in master is different. I didn't try master so far.

@cennoreth
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants