-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Walkthrough, as_grey option not working, png images have 4 channels #23
Comments
I just read the code of pims and I think it's fixed in master. |
Still broken in the version I have! |
@cennoreth What's your pims version? master freshly build? |
yes, I think so - how do I check? |
If it's correctly done in pims, this should tell you if you use the git version or a released version.
|
I'm with 0.2.2 and it doesn't work, but the implementation in master is different. I didn't try master so far. |
It works with these images: https://github.com/soft-matter/pims/tree/master/examples/image_sequence But not with these: https://github.com/soft-matter/trackpy-examples/tree/master/sample_data/bulk_water Ah - version is also 0.2.2 |
Hi,
I'm preparing a tutorial for my lab on trackpy and going though the walkthrough notebook, I noticed that the png images have 4 channels
frames = pims.ImageSequence('../sample_data/bulk_water/*.png', as_grey=True)
raises
NotImplementedError: I don't know how to convert an image of shaped (424, 640, 4) to greyscale. Write you own function and pass it using the process_func keyword argument.
I can fix the notebook. Do you prefer to keep the use of as_grey option or show how to write a preprocess function...
Might be worth to illustrate both too. I don't know of the preprocess kwarg is illustrated somewhere.
Best
The text was updated successfully, but these errors were encountered: