Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SofaBootRpcStartListener 还未跟随新版本 5.13.2 更新 lookout 移除问题 #1456

Closed
Jiiiiiin opened this issue Oct 19, 2024 · 2 comments
Labels
wontfix This will not be worked on

Comments

@Jiiiiiin
Copy link

Jiiiiiin commented Oct 19, 2024

SofaBootRpcStartListener 还未跟随新版本 5.13.2 更新 lookout 移除问题

#1447 但是上游 sofa-boot 特别是 rpc-sofa-boot-starter SofaBootRpcStartListener 缺失更新:

image

Your scenes

  • sofa-boot 3.24.0

  • sofa-rpc-all 单独更新:

    <rpc.core.version>5.13.2</rpc.core.version>

    <sofa.bolt.version>1.6.10</sofa.bolt.version>

    <sofa.hessian.version>3.5.5</sofa.hessian.version>
    <tracer.core.version>3.1.6</tracer.core.version>
    <sofa.common.tools.version>1.4.0</sofa.common.tools.version>

    <commons-io.version>2.14.0</commons-io.version>
    <guava-jre.version>32.0.0-jre</guava-jre.version>
    <netty.version>4.1.44.Final</netty.version>

    <resteasy.version>3.14.0.Final</resteasy.version>

    <javassist.version>3.29.2-GA</javassist.version>
    <bytebuddy.version>1.9.8</bytebuddy.version>

    <logback.version>1.2.13</logback.version>

Your advice

因为有些 CVE 内部检测,需要单独更新 sofa-rpc-all

Environment

  • SOFARPC version:5.13.2
  • JVM version (e.g. java -version):openjdk version "1.8.0_422"
  • OS version (e.g. uname -a): Darwin
@Jiiiiiin
Copy link
Author

Jiiiiiin commented Oct 19, 2024

目前仅仅能在项目,直接“覆盖”:

package com.alipay.sofa.rpc.event;

/**
 * Collect the raw information for lookout by listening to events.
 *
 * @author <a href="mailto:[email protected]">LiWei.Liangen</a>
 */
public class LookoutSubscriber extends Subscriber {

  public static void setLookoutCollectDisable(boolean lookoutCollectDisable) {
    // LookoutSubscriber.lookoutCollectDisable = lookoutCollectDisable;
  }

  @Override
  public void onEvent(Event event) {

  }
}

如果移除了整个 lookout 那么感觉这个应该没有影响。

已经向下游提交修复,但是不知道是否合规:

sofastack/sofa-boot#1348

sofastack/sofa-boot#1347

Copy link

stale bot commented Dec 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 19, 2024
@stale stale bot closed this as completed Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant