Skip to content

Commit ebd62d5

Browse files
authored
fix typo (#895)
Signed-off-by: debug-zhang <zh.xinze@gmail.com>
1 parent 0aa099f commit ebd62d5

18 files changed

Lines changed: 24 additions & 24 deletions

File tree

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
## Contributing to SOFABoot
22

33
SOFABoot is released under the Apache 2.0 license, and follows a very
4-
standard Github development process, using Github tracker for issues and
4+
standard GitHub development process, using GitHub tracker for issues and
55
merging pull requests into master . If you would like to contribute something,
66
or simply want to hack on the code this document should help you get started.
77

88
### Sign the Contributor License Agreement
99
Before we accept a non-trivial patch or pull request we will need you to
1010
sign the Contributor License Agreement. Signing the contributor’s agreement
11-
does not grant anyone commit rights to the main repository, but it does mean
11+
does not grant anyone commits rights to the main repository, but it does mean
1212
that we can accept your contributions, and you will get an author credit if
1313
we do. Active contributors might be asked to join the core team, and given
1414
the ability to merge pull requests.
1515

1616
### Code Conventions
1717
None of these is essential for a pull request, but they will all help.
1818

19-
1. we provided a [code formatter file](tools/Formatter.xml), it will formatting
19+
1. we provided a [code formatter file](tools/Formatter.xml), it will format
2020
automatically your project when during process of building.
2121

2222
2. Make sure all new `.java` files to have a simple Javadoc class comment

sofa-boot-project/sofa-boot-core/healthcheck-sofa-boot/src/main/java/com/alipay/sofa/healthcheck/ReadinessCheckListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ public void onAvailabilityChangeEvent(AvailabilityChangeEvent<?> event) {
139139
if (isReadinessCheckFinish()) {
140140
Object payload = event.getPayload();
141141
if (payload instanceof ReadinessState && payload != readinessState) {
142-
// If readinessCheck if performed normally, readinessState won't be null
142+
// If readinessCheck is performed normally, readinessState won't be null
143143
// it means application is in critical state if it is
144144
if (readinessState == null) {
145145
AvailabilityChangeEvent.publish(applicationContext,

sofa-boot-project/sofa-boot-core/isle-sofa-boot/src/main/java/com/alipay/sofa/isle/deployment/DependencyTree.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class DependencyTree<K, T> implements Iterable<DependencyTree.Entry<K, T>
3737

3838
// the sorted list of resolved entries.
3939
// given an element e from that list it is ensured that any element at the left
40-
// of 'e' doesn't depends on it
40+
// of 'e' doesn't depend on it
4141
private final List<Entry<K, T>> resolved;
4242

4343
public DependencyTree() {

sofa-boot-project/sofa-boot-core/isle-sofa-boot/src/main/java/com/alipay/sofa/isle/deployment/impl/FileDeploymentDescriptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public void loadSpringXMLs() {
4848

4949
try {
5050
// When path contains special characters (e.g., white space, Chinese), URL converts them to UTF8 code point.
51-
// In order to processing correctly, create File from URI
51+
// In order to process correctly, create File from URI
5252
URI springXmlUri = new URI("file://"
5353
+ url.getFile().substring(
5454
0,

sofa-boot-project/sofa-boot-core/isle-sofa-boot/src/main/java/com/alipay/sofa/isle/profile/SofaModuleProfileChecker.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@
2626
public interface SofaModuleProfileChecker {
2727

2828
/***
29-
* determine whether the module should be activate
29+
* determine whether the module should be activated
3030
*
3131
* @param sofaModuleProfiles sofa module profiles
3232
* @return true or false
3333
*/
3434
boolean acceptProfiles(String[] sofaModuleProfiles);
3535

3636
/**
37-
* determine whether the module should be activate
37+
* determine whether the module should be activated
3838
*
3939
* @param deploymentDescriptor
4040
* @return

sofa-boot-project/sofa-boot-core/isle-sofa-boot/src/main/java/com/alipay/sofa/isle/spring/SofaModuleContextLifecycle.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
/**
2929
* SofaModuleContextLifecycle is a SmartLifecycle bean which will be started after ApplicationContext refreshed.
30-
* SofaModuleContextLifecycle has -100 phase, which overrides default lowest order, and has following effect:
30+
* SofaModuleContextLifecycle has -100 phase, which overrides default the lowest order, and has the following effect:
3131
* 1. Start before default Lifecycle bean.
3232
* 2. Any other bean has option to precede.
3333
*

sofa-boot-project/sofa-boot-core/rpc-sofa-boot/src/main/java/com/alipay/sofa/rpc/boot/common/NetworkAddressUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public class NetworkAddressUtil {
4343
private static String DEFAULT_HOST_NAME = "app";
4444

4545
/**
46-
* this method should be invoked fisrt
46+
* this method should be invoked first
4747
*
4848
* @param enabledIpRange
4949
* @param bindNetworkInterface

sofa-boot-project/sofa-boot-core/rpc-sofa-boot/src/test/java/com/alipay/sofa/rpc/boot/test/adapter/BindingAdapterFactoryTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
/**
2626
* @author zhaowang
27-
* @version : BindingAdatperFactoryTest.java, v 0.1 2020年02月05日 2:46 下午 zhaowang Exp $
27+
* @version : BindingAdapterFactoryTest.java, v 0.1 2020年02月05日 2:46 下午 zhaowang Exp $
2828
*/
2929
public class BindingAdapterFactoryTest {
3030

sofa-boot-project/sofa-boot-core/rpc-sofa-boot/src/test/java/com/alipay/sofa/rpc/boot/test/bean/direct/DirectService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@
2121
*/
2222
public interface DirectService {
2323

24-
String sayDirect(String stirng);
24+
String sayDirect(String string);
2525

2626
}

sofa-boot-project/sofa-boot-core/rpc-sofa-boot/src/test/java/com/alipay/sofa/rpc/boot/test/bean/direct/DirectServiceImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
*/
2222
public class DirectServiceImpl implements DirectService {
2323
@Override
24-
public String sayDirect(String stirng) {
25-
return stirng;
24+
public String sayDirect(String string) {
25+
return string;
2626
}
2727
}

0 commit comments

Comments
 (0)