From c110ab226a1914f4fc927a1b217dcf637dbb047b Mon Sep 17 00:00:00 2001 From: HolyWalley Date: Tue, 2 Sep 2025 15:29:38 +0200 Subject: [PATCH 1/3] Allow options in compatible logger --- lib/console/compatible/logger.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/console/compatible/logger.rb b/lib/console/compatible/logger.rb index ce7ca2a..865d014 100644 --- a/lib/console/compatible/logger.rb +++ b/lib/console/compatible/logger.rb @@ -62,7 +62,7 @@ def initialize(subject, output = Console) # @parameter message [String] The message to log. # @parameter progname [String] The program name. # @returns [Boolean] True if the message was logged. - def add(severity, message = nil, progname = nil) + def add(severity, message = nil, progname = nil, **options) severity ||= UNKNOWN if @logdev.nil? or severity < level @@ -84,6 +84,7 @@ def add(severity, message = nil, progname = nil) @logdev.call( progname, message, + **options, severity: format_severity(severity) ) From 2edb98cc424a110e981c9dd44216e1503d274c02 Mon Sep 17 00:00:00 2001 From: HolyWalley Date: Thu, 4 Sep 2025 14:46:19 +0200 Subject: [PATCH 2/3] Add test for options in compatible logger --- test/console/compatible/logger.rb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/console/compatible/logger.rb b/test/console/compatible/logger.rb index 1b39047..ecce83f 100644 --- a/test/console/compatible/logger.rb +++ b/test/console/compatible/logger.rb @@ -43,4 +43,10 @@ expect(logger.level).to be_a(Integer) expect(logger.level).to be == ::Logger::DEBUG end + + it "accepts keyword arguments and passes them to the log device" do + logger.add(Logger::INFO, "Hello World", request_id: 137) + + expect(stream.string).to be(:include?, '"request_id": 137') + end end From 927d54c1e5ff84fef52914c13f0f1ed49700213d Mon Sep 17 00:00:00 2001 From: Samuel Williams Date: Fri, 5 Sep 2025 22:34:02 +1200 Subject: [PATCH 3/3] Update test/console/compatible/logger.rb --- test/console/compatible/logger.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/console/compatible/logger.rb b/test/console/compatible/logger.rb index ecce83f..3f3decc 100644 --- a/test/console/compatible/logger.rb +++ b/test/console/compatible/logger.rb @@ -43,10 +43,10 @@ expect(logger.level).to be_a(Integer) expect(logger.level).to be == ::Logger::DEBUG end - + it "accepts keyword arguments and passes them to the log device" do logger.add(Logger::INFO, "Hello World", request_id: 137) - + expect(stream.string).to be(:include?, '"request_id": 137') end end