-
-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Description
Some tests are logging connection errors (usually ones testing error handling):
> bundle exec sus test/async/http/retry.rb:36
0.1s warn: Async::Task: Reading HTTP/1.1 requests for Async::HTTP::Protocol::HTTP1::Server. [oid=0x4d8] [ec=0x4e0] [pid=77118] [2025-03-12 17:23:34 +1300]
| Task may have ended with unhandled exception.
| Errno::ECONNRESET: Connection reset by peer
| → <internal:io> 63:in 'IO#read_nonblock'
| /Users/samuel/.gem/ruby/3.4.2/gems/io-stream-0.6.1/lib/io/stream/buffered.rb:114 in 'IO::Stream::Buffered#sysread'
| /Users/samuel/.gem/ruby/3.4.2/gems/io-stream-0.6.1/lib/io/stream/generic.rb:327 in 'IO::Stream::Generic#fill_read_buffer'
| /Users/samuel/.gem/ruby/3.4.2/gems/io-stream-0.6.1/lib/io/stream/generic.rb:164 in 'IO::Stream::Generic#gets'
| /Users/samuel/.gem/ruby/3.4.2/gems/protocol-http1-0.30.0/lib/protocol/http1/connection.rb:289 in 'Protocol::HTTP1::Connection#read_line?'
| /Users/samuel/.gem/ruby/3.4.2/gems/protocol-http1-0.30.0/lib/protocol/http1/connection.rb:304 in 'Protocol::HTTP1::Connection#read_request_line'
| /Users/samuel/.gem/ruby/3.4.2/gems/protocol-http1-0.30.0/lib/protocol/http1/connection.rb:318 in 'Protocol::HTTP1::Connection#read_request'
| lib/async/http/protocol/http1/request.rb:26 in 'Async::HTTP::Protocol::HTTP1::Request.read'
| lib/async/http/protocol/http1/server.rb:48 in 'Async::HTTP::Protocol::HTTP1::Server#next_request'
| lib/async/http/protocol/http1/server.rb:65 in 'Async::HTTP::Protocol::HTTP1::Server#each'
| lib/async/http/server.rb:50 in 'Async::HTTP::Server#accept'
| /Users/samuel/.gem/ruby/3.4.2/gems/io-endpoint-0.15.2/lib/io/endpoint/wrapper.rb:216 in 'block (2 levels) in IO::Endpoint::Wrapper#accept'
| /Users/samuel/.gem/ruby/3.4.2/gems/async-2.23.1/lib/async/task.rb:200 in 'block in Async::Task#run'
| /Users/samuel/.gem/ruby/3.4.2/gems/async-2.23.1/lib/async/task.rb:438 in 'block in Async::Task#schedule'
1 passed out of 1 total (1 assertions)
🏁 Finished in 155.3ms; 6.44 assertions per second.
🐢 Slow tests:
155.2ms: describe consistent retry behaviour it retries with empty body test/async/http/retry.rb:36
But not all the time. I think we should correctly capture expected logs so that unexpected error logs can be identified.
Metadata
Metadata
Assignees
Labels
No labels