Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit RemoveChannel from deleting a channel being listened to #5

Open
gavin-norman-sociomantic opened this issue Sep 28, 2017 · 0 comments

Comments

@gavin-norman-sociomantic

sociomantic-tsunami/dhtproto#10 discusses problems around ending a DHT Mirror request when the channel being mirrored is deleted. The same argument applies to the DMQ Consume request.

Discussion led to the idea that it should actually be illegal to remove a channel that is being listened to. RemoveChannel is used in two cases:

  1. By accident.
  2. Deliberately, to remove a channel which is no longer in use.

In both cases, the request should definitely not work on a channel that's currently in use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant