Set length of array before casting #2
Labels
Comments
david-eckardt-sociomantic
added a commit
to david-eckardt-sociomantic/dmqproto
that referenced
this issue
Feb 2, 2018
Fixes sociomantic-tsunami#2. - Use `VoidBufferAsArrayOf!(cstring)` instead of `cast(cstring[]*)`, which is dangerous because the array length is set after the cast. - Set the array length once instead of appending incrementally. - Use `parseBody` to parse the value to enforce it is the last field in the message payload.
gavin-norman-sociomantic
pushed a commit
that referenced
this issue
Feb 2, 2018
Fixes #2. - Use `VoidBufferAsArrayOf!(cstring)` instead of `cast(cstring[]*)`, which is dangerous because the array length is set after the cast. - Set the array length once instead of appending incrementally. - Use `parseBody` to parse the value to enforce it is the last field in the message payload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/sociomantic-tsunami/dmqproto/blob/v13.x.x/src/dmqproto/node/neo/request/Push.d#L57-L64 appears to be dancing in undefined behaviour territory. (See https://github.com/gavin-norman-sociomantic/swarm-tsunami/blob/3428d7cca0171ce4f802da6fbed52606a071295c/src/swarm/neo/util/AcquiredResources.d#L71-L100.)
The text was updated successfully, but these errors were encountered: