NEXT-35982 - Add devops tests to integration job

Author: keulinho

.gitlab/stages/20-unit.yml

@@ -91,7 +91,7 @@ PHP integration:
       --configuration phpunit.xml.dist
       --log-junit phpunit.junit.xml
       --exclude-group=needsWebserver,skip-paratest,not-deterministic
-      --testsuite integration
+      --testsuite integration,devops
       --order-by default
 
 PHP bench:

phpstan.neon.dist

@@ -86,6 +86,7 @@ parameters:
                 - src/**/*Test.php
                 - tests/performance/**/*Bench.php
                 - tests/unit/**/*Test.php
+                - tests/devops/**/*Test.php
                 - tests/integration/**/*Test.php
                 - tests/integration/**/*TestCase.php
 

tests/integration/Core/DevOps/Docs/Command/App/DocsAppEventCommandTest.php tests/devops/Core/DevOps/Docs/Command/App/DocsAppEventCommandTest.php

@@ -1,11 +1,10 @@
 <?php declare(strict_types=1);
 
-namespace Shopware\Tests\Integration\Core\DevOps\Docs\Command\App;
+namespace Shopware\Tests\DevOps\Core\DevOps\Docs\Command\App;
 
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
 use Shopware\Core\DevOps\Docs\App\DocsAppEventCommand;
-use Shopware\Core\Framework\Feature;
 use Shopware\Core\Framework\Test\TestCaseBase\IntegrationTestBehaviour;
 
 /**

tests/integration/Core/DevOps/Docs/Command/Script/ScriptReferenceGeneratorTest.php tests/devops/Core/DevOps/Docs/Command/Script/ScriptReferenceGeneratorTest.php

@@ -1,6 +1,6 @@
 <?php declare(strict_types=1);
 
-namespace Shopware\Tests\Integration\Core\DevOps\Docs\Command\Script;
+namespace Shopware\Tests\DevOps\Core\DevOps\Docs\Command\Script;
 
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;

tests/integration/Core/DevOps/DevOps/StaticAnalyse/Coverage/Command/GetClassesPerAreaCommandTest.php tests/devops/Core/DevOps/StaticAnalyse/Coverage/Command/GetClassesPerAreaCommandTest.php

@@ -1,8 +1,7 @@
 <?php declare(strict_types=1);
 
-namespace Shopware\Tests\Integration\Core\DevOps\DevOps\StaticAnalyse\Coverage\Command;
+namespace Shopware\Tests\DevOps\Core\DevOps\StaticAnalyse\Coverage\Command;
 
-use Composer\Autoload\ClassLoader;
 use PHPUnit\Framework\Attributes\After;
 use PHPUnit\Framework\Attributes\Before;
 use PHPUnit\Framework\TestCase;
@@ -11,12 +10,10 @@
 use Shopware\Core\DevOps\StaticAnalyze\Coverage\Command\GetClassesPerAreaCommand;
 use Shopware\Core\Framework\Framework;
 use Shopware\Core\Framework\Test\TestCaseBase\KernelTestBehaviour;
-use Shopware\Core\Framework\Test\TestCaseHelper\ReflectionHelper;
 use Shopware\Core\System\System;
 use Shopware\Elasticsearch\Elasticsearch;
 use Shopware\Storefront\Storefront;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Output\BufferedOutput;
+use Symfony\Component\Console\Tester\CommandTester;
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\Finder\Finder;
 
@@ -31,8 +28,8 @@ class GetClassesPerAreaCommandTest extends TestCase
     #[After]
     public function cleanUp(): void
     {
+        $projectDir = $_SERVER['PROJECT_ROOT'];
         $filesystem = new Filesystem();
-        $projectDir = $this->getProjectDir();
 
         $finder = new Finder();
         $phpunitFiles = $finder->in($projectDir)
@@ -43,6 +40,15 @@ public function cleanUp(): void
         $filesystem->remove($phpunitFiles);
     }
 
+    protected function setUp(): void
+    {
+        $projectDir = $_SERVER['PROJECT_ROOT'];
+
+        if (!file_exists($projectDir . '/vendor/shopware/core') || !file_exists($projectDir . '/vendor/shopware/platform')) {
+            static::markTestSkipped('This test expects shopware installed over composer and does not work with the git setup');
+        }
+    }
+
     public function testGetClasses(): void
     {
         // if the test does not find any shopware classes run: composer dump-autoload -o
@@ -107,7 +113,7 @@ public function testGeneratedPhpunitFiles(): void
         }
 
         foreach ($areas as $area => $classes) {
-            $phpunitFile = $this->getProjectDir() . '/phpunit.' . $area . '.xml';
+            $phpunitFile = $_SERVER['PROJECT_ROOT'] . '/phpunit.' . $area . '.xml';
             $coveredFiles = $this->getCoveredFiles($phpunitFile);
             foreach ($classes as $class) {
                 static::assertContains((new \ReflectionClass($class))->getFileName(), $coveredFiles);
@@ -127,29 +133,11 @@ private function isBundleLoaded(string $bundleName): bool
      */
     private function runCommand(array $parameters): string
     {
-        $projectDir = $this->getProjectDir();
+        $tester = new CommandTester(new GetClassesPerAreaCommand($_SERVER['PROJECT_ROOT']));
 
-        $getClassesCommand = new GetClassesPerAreaCommand($projectDir);
-        $definition = $getClassesCommand->getDefinition();
-        $input = new ArrayInput(
-            $parameters,
-            $definition
-        );
-        $input->getOptions();
-        $output = new BufferedOutput();
-
-        $refMethod = ReflectionHelper::getMethod(GetClassesPerAreaCommand::class, 'execute');
-        $refMethod->invoke($getClassesCommand, $input, $output);
-
-        return $output->fetch();
-    }
-
-    private function getProjectDir(): string
-    {
-        $vendorDir = key(ClassLoader::getRegisteredLoaders());
-        static::assertIsString($vendorDir);
+        $tester->execute($parameters);
 
-        return \dirname($vendorDir);
+        return $tester->getDisplay();
     }
 
     /**

tests/integration/Core/DevOps/DevOps/StaticAnalyse/Coverage/Command/GetJSFilesPerAreaCommandTest.php tests/devops/Core/DevOps/StaticAnalyse/Coverage/Command/GetJSFilesPerAreaCommandTest.php

@@ -1,14 +1,12 @@
 <?php declare(strict_types=1);
 
-namespace Shopware\Tests\Integration\Core\DevOps\DevOps\StaticAnalyse\Coverage\Command;
+namespace Shopware\Tests\DevOps\Core\DevOps\StaticAnalyse\Coverage\Command;
 
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Shopware\Administration\Administration;
 use Shopware\Core\DevOps\StaticAnalyze\Coverage\Command\GetJSFilesPerAreaCommand;
-use Shopware\Core\Framework\Test\TestCaseHelper\ReflectionHelper;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Output\BufferedOutput;
+use Symfony\Component\Console\Tester\CommandTester;
 
 /**
  * @internal
@@ -67,18 +65,10 @@ public static function pathAreaDataProvider(): array
      */
     private function runCommand(array $parameters): string
     {
-        $getClassesCommand = new GetJSFilesPerAreaCommand();
-        $definition = $getClassesCommand->getDefinition();
-        $input = new ArrayInput(
-            $parameters,
-            $definition
-        );
-        $input->getOptions();
-        $output = new BufferedOutput();
+        $tester = new CommandTester(new GetJSFilesPerAreaCommand());
 
-        $refMethod = ReflectionHelper::getMethod(GetJSFilesPerAreaCommand::class, 'execute');
-        $refMethod->invoke($getClassesCommand, $input, $output);
+        $tester->execute($parameters);
 
-        return $output->fetch();
+        return $tester->getDisplay();
     }
 }

tests/integration/Core/DevOps/DevOps/StaticAnalyse/Coverage/Command/SummarizeCoverageReportsTest.php tests/devops/Core/DevOps/StaticAnalyse/Coverage/Command/SummarizeCoverageReportsTest.php

@@ -1,15 +1,12 @@
 <?php declare(strict_types=1);
 
-namespace Shopware\Tests\Integration\Core\DevOps\DevOps\StaticAnalyse\Coverage\Command;
+namespace Shopware\Tests\DevOps\Core\DevOps\StaticAnalyse\Coverage\Command;
 
-use Composer\Autoload\ClassLoader;
 use PHPUnit\Framework\Attributes\After;
 use PHPUnit\Framework\Attributes\Before;
 use PHPUnit\Framework\TestCase;
 use Shopware\Core\DevOps\StaticAnalyze\Coverage\Command\SummarizeCoverageReports;
-use Shopware\Core\Framework\Test\TestCaseHelper\ReflectionHelper;
-use Symfony\Component\Console\Input\ArrayInput;
-use Symfony\Component\Console\Output\BufferedOutput;
+use Symfony\Component\Console\Tester\CommandTester;
 use Symfony\Component\Filesystem\Filesystem;
 use Twig\Environment;
 use Twig\Loader\ArrayLoader;
@@ -23,7 +20,7 @@ class SummarizeCoverageReportsTest extends TestCase
     public function copyFixtures(): void
     {
         $filesystem = new Filesystem();
-        $projectDir = $this->getProjectDir();
+        $projectDir = $_SERVER['PROJECT_ROOT'];
 
         $filesystem->mirror(__DIR__ . '/_fixtures/coverage', $projectDir . '/coverage');
     }
@@ -32,7 +29,7 @@ public function copyFixtures(): void
     public function deleteTestFiles(): void
     {
         $filesystem = new Filesystem();
-        $projectDir = $this->getProjectDir();
+        $projectDir = $_SERVER['PROJECT_ROOT'];
 
         $filesystem->remove($projectDir . '/coverage');
         $filesystem->remove($projectDir . '/coverageSummary.html');
@@ -41,9 +38,9 @@ public function deleteTestFiles(): void
 
     public function testSummarize(): void
     {
-        $this->runCommand([]);
+        $this->runCommand();
 
-        $projectDir = $this->getProjectDir();
+        $projectDir = $_SERVER['PROJECT_ROOT'];
 
         static::assertFileExists($projectDir . '/coverageSummary.json');
         static::assertFileExists($projectDir . '/coverageSummary.html');
@@ -109,31 +106,12 @@ public function testSummarize(): void
         ], $coverageReport['js']);
     }
 
-    /**
-     * @param mixed[] $parameters
-     */
-    private function runCommand(array $parameters): string
+    private function runCommand(): string
     {
-        $getClassesCommand = new SummarizeCoverageReports($this->getProjectDir(), new Environment(new ArrayLoader()));
-        $definition = $getClassesCommand->getDefinition();
-        $input = new ArrayInput(
-            $parameters,
-            $definition
-        );
-        $input->getOptions();
-        $output = new BufferedOutput();
-
-        $refMethod = ReflectionHelper::getMethod(SummarizeCoverageReports::class, 'execute');
-        $refMethod->invoke($getClassesCommand, $input, $output);
-
-        return $output->fetch();
-    }
+        $tester = new CommandTester(new SummarizeCoverageReports($_SERVER['PROJECT_ROOT'], new Environment(new ArrayLoader())));
 
-    private function getProjectDir(): string
-    {
-        $vendorDir = key(ClassLoader::getRegisteredLoaders());
-        static::assertIsString($vendorDir);
+        $tester->execute([]);
 
-        return \dirname($vendorDir);
+        return $tester->getDisplay();
     }
 }