feat: remove HEAD fast path for scraper #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most services are built without support for serving a HEAD request to their openapi endpoints. Currently we fall back to the normal GET path if the service returns method not supported. It would take a lot of effort to update each service to support handling HEAD requests, for not much benefit. The normal GET path is fast enough without having this fast path. Having this path is just making noise in metrics for people logging client errors.
malinbranduse
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most services are built without support for serving a HEAD request to their openapi endpoints. Currently we fall back to the normal GET path if the service returns method not supported.
It would take a lot of effort to update each service to support handling HEAD requests, for not much benefit. The normal GET path is fast enough without having this fast path.
Having this path is just making noise in metrics for people logging client errors.