Fix/outputs from multi paths #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vervet config allows both Path and Paths to be defined on the output. This function assumed that only the former was populated so wouldn't return specs if only the latter was populated. This seems like a footgun that will happen again so it would be good to change the types so this doesn't happen again.
jgresty
force-pushed
the
fix/outputs-from-multi-paths
branch
3 times, most recently
from
2fa81be to
b66104f
Compare
Having both Output.Path and Output.Paths was a source of errors waiting to happen if the caller didn't call ResolvePaths first. This patch resolves the paths when deserialising so it reduces the mental load overall.
jgresty
force-pushed
the
fix/outputs-from-multi-paths
branch
from
b66104f to
e7c2f64
Compare
RaduPetreTarean
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vervet config allows both Path and Paths to be defined on the output.
GetOutputSpecs assumed that only the former was populated so wouldn't return specs if
only the latter was populated.
Having both Output.Path and Output.Paths was a source of errors waiting to
happen if the caller didn't call ResolvePaths first. This patch resolves the
paths when deserialising so it reduces the mental load overall.