chore: EXT-2825 upgrade jsonpath to fix critical vuln #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
acaprar
force-pushed
the
chore/EXT-2825-upgrade-jsonpath
branch
from
0e099d2 to
2e84b31
Compare
acaprar
commented
Feb 18, 2025
| @@ -67,7 +67,8 @@ | |||
| "yargs": "~17.6.0" | |||
| }, | |||
| "overrides": { | |||
| "postman-collection": "4.2.0" | |||
| "postman-collection": "4.2.0", | |||
| "jsonpath-plus": "^10.3.0" | |||
There was a problem hiding this comment.
Because we run npm ci in our test pipeline, package.json and package-lock.json need to be in sync other
jgresty
reviewed
Feb 18, 2025
| @@ -5393,15 +5393,6 @@ | |||
| "openid-client": "^5.3.0" | |||
| } | |||
| }, | |||
| "node_modules/@kubernetes/client-node/node_modules/jsonpath-plus": { | |||
| "version": "7.2.0", | |||
There was a problem hiding this comment.
That is a big version change, are you sure this isn't going to break something?
There was a problem hiding this comment.
from the tests it seems to be fine, but if you think the tests do not cover all scenarios then we could set jsonpath to 10.3.0 except for @kubernetes/client-node || update @kubernetes/client-node
jgresty
approved these changes
Feb 18, 2025
|
🎉 This PR is included in version 3.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a Critical sev in sweater-comb:
Because of this, other projects are affected.
In order to fix it, we need to upgrade jsonpath-plus to 10.3.0