From 99884e27d6079374c807f001405ad5d6ca6fa728 Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 9 Oct 2024 16:02:26 -0400 Subject: [PATCH 1/2] adjusting `setup.py` for GHA --- requires-install.txt | 1 + setup.py | 10 +++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 requires-install.txt diff --git a/requires-install.txt b/requires-install.txt new file mode 100644 index 00000000..ca8b394c --- /dev/null +++ b/requires-install.txt @@ -0,0 +1 @@ +dash>=2 \ No newline at end of file diff --git a/setup.py b/setup.py index d9e4b5dc..653f509a 100644 --- a/setup.py +++ b/setup.py @@ -8,6 +8,11 @@ package_name = package["name"].replace(" ", "_").replace("-", "_") +def read_req_file(req_type): + with open(f"requires-{req_type}.txt", encoding="utf-8") as fp: + requires = (line.strip() for line in fp) + return [req for req in requires if req and not req.startswith("#")] + setup( name=package_name, url=package["homepage"], @@ -18,7 +23,10 @@ include_package_data=True, license=package["license"], description=package.get("description", package_name), - install_requires=[], + install_requires=read_req_file("install"), + extras_require={ + "dev": read_req_file("dev"), + }, classifiers=[ "Framework :: Dash", "Framework :: Flask", From 3cfde84a5bfc0cd1eb74698d467ebb658d87ae90 Mon Sep 17 00:00:00 2001 From: BSd3v <82055130+BSd3v@users.noreply.github.com> Date: Wed, 9 Oct 2024 16:04:35 -0400 Subject: [PATCH 2/2] stripping `18.2` reference, as this package already requires `18` --- .github/workflows/python-test.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/python-test.yml b/.github/workflows/python-test.yml index 10691a08..d984b75e 100644 --- a/.github/workflows/python-test.yml +++ b/.github/workflows/python-test.yml @@ -11,9 +11,6 @@ on: jobs: test-react: runs-on: ubuntu-latest - strategy: - matrix: - react-version: ["18.2.0"] steps: - uses: actions/checkout@v3 - uses: actions/setup-python@v3 @@ -40,9 +37,7 @@ jobs: uv pip install --upgrade pip uv pip install wheel uv pip install ".[dev]" - echo "Using React version ${{ matrix.react-version }}" npm ci - npm install react@${{ matrix.react-version }} react-dom@${{ matrix.react-version }} npm i npm run build timeout-minutes: 20