Problem
#67 / #68 color the #NN PR-number suffix by review state (green approved, red changes-requested, …). Color alone is an accessibility gap: red/green are the two most important states and are indistinguishable for red-green colorblind users (~8% of men). We want a redundant, non-color signal.
Why not full text labels
Considered (and rejected) showing approved / changes requested as words: they're wide and variable-width, which fights the ref column's plain-text padding (it keeps the timestamp columns aligned). Duplicating the state as prose on every row is a lot of horizontal real estate for what a compact marker conveys.
Proposed
A small glyph/letter riding next to the number, mirroring the CI ✓/✗/●/○ glyph pattern in render.go (checkGlyph). Strawman:
| State |
Color |
Marker (strawman) |
| approved |
green |
#58 ✓ |
| changes requested |
red |
#58 ± |
| review required |
yellow |
#58 … |
| draft |
dim |
#58 · |
| open, no decision |
plain |
#58 (none) |
Always-on (the point is the non-color channel), so no toggle to maintain.
Design fork (why hitl)
- Exact glyph set —
✓/±/…/· vs letters (A/C/R/D) vs something else. Must stay single-width and not collide visually with the CI glyph column.
- Placement: after the number (
#58 ±) vs a dedicated column.
- Width/alignment: the suffix padding in
refCell is measured on plain text — adding a marker needs the same care so columns stay aligned.
Data is already in place: Worktree.PRReview (added in #68). This is render-only.
Problem
#67 / #68 color the
#NNPR-number suffix by review state (green approved, red changes-requested, …). Color alone is an accessibility gap: red/green are the two most important states and are indistinguishable for red-green colorblind users (~8% of men). We want a redundant, non-color signal.Why not full text labels
Considered (and rejected) showing
approved/changes requestedas words: they're wide and variable-width, which fights the ref column's plain-text padding (it keeps the timestamp columns aligned). Duplicating the state as prose on every row is a lot of horizontal real estate for what a compact marker conveys.Proposed
A small glyph/letter riding next to the number, mirroring the CI
✓/✗/●/○glyph pattern inrender.go(checkGlyph). Strawman:#58 ✓#58 ±#58 …#58 ·#58(none)Always-on (the point is the non-color channel), so no toggle to maintain.
Design fork (why
hitl)✓/±/…/·vs letters (A/C/R/D) vs something else. Must stay single-width and not collide visually with the CI glyph column.#58 ±) vs a dedicated column.refCellis measured on plain text — adding a marker needs the same care so columns stay aligned.Data is already in place:
Worktree.PRReview(added in #68). This is render-only.