punch 20250917#54
Merged
smartwatermelon merged 7 commits intomainfrom Sep 17, 2025
Merged
Conversation
Owner
smartwatermelon
commented
Sep 17, 2025
- Improve first-boot completion workflow with Terminal window management
- Fix FileVault disable verification to prevent false success messages
- Apply pre-commit hook formatting fixes for FileVault retry loop
- fdesetup user verbose
- Add prominent VPN security warning to Transmission documentation
- space
- Fix Terminal profile window management to prevent closing calling script window
Replace verbose completion text with streamlined AppleScript dialog and automatic Terminal window opening. This solves zsh compatibility issues by ensuring users start app setup in a fresh bash environment. Changes: - Add completion dialog with concise messaging - Automatically open new Terminal window in app-setup directory - Remove verbose next-steps output in favor of guided workflow - Provide clear closure message for original Terminal window 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add proper verification after fdesetup disable command to ensure FileVault was actually disabled. The fdesetup disable command returns exit code 0 even when it fails due to incorrect passwords, leading to misleading success messages. Changes: - Re-check FileVault status after disable attempt using fdesetup status - Provide accurate feedback based on actual system state - Clear error messaging when disable fails due to wrong password - Maintain same alternative options for all failure scenarios Fixes issue where users saw "FileVault disabled successfully" even when entering wrong passwords. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Pre-commit hooks applied code formatting improvements to the FileVault retry loop implementation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add critical security callout at top of transmission-setup-README.md emphasizing VPN binding recommendation for privacy protection during BitTorrent operations. Changes: - Add prominent warning callout with security icon - Clearly state VPN binding is strongly recommended for privacy - Explicitly note VPN functionality is NOT included in automation - Direct users to consult VPN provider documentation for manual setup - Position warning before all technical content for maximum visibility Ensures users understand security implications and manual configuration requirements before deployment. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…ipt window Replace fragile window ID tracking with safer approach that preserves the calling script's window. Instead of attempting to close the new profile window, save reference to current window, open profile, then restore focus to calling window. Changes: - Save reference to calling script's window before opening profile - Remove complex window ID tracking and selective closing logic - Use window focus restoration instead of window closing - Add verification loop to ensure calling window returns to front - Update success message to reflect new behavior Eliminates risk of accidentally closing the window running the setup script during Terminal profile import. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.