Improve finnhub resources (#4335)

Author: mxiao-cll

.changeset/quick-cherries-invite.md

@@ -0,0 +1,5 @@
+---
+'@chainlink/finnhub-adapter': patch
+---
+
+Optimize resources

packages/sources/finnhub/src/config/index.ts

@@ -1,35 +1,28 @@
 import { AdapterConfig } from '@chainlink/external-adapter-framework/config'
 
-export const config = new AdapterConfig(
-  {
-    API_ENDPOINT: {
-      description: 'The HTTP URL to retrieve data from',
-      type: 'string',
-      default: 'https://finnhub.io/api/v1',
-    },
-    API_KEY: {
-      description: 'A Finnhub API key ',
-      type: 'string',
-      required: true,
-      sensitive: true,
-    },
-    WS_API_ENDPOINT: {
-      description: 'The WS URL to retrieve data from',
-      type: 'string',
-      default: 'wss://ws.finnhub.io',
-    },
-    WS_ENABLED: {
-      description: 'Whether data should be returned from websocket or not',
-      type: 'boolean',
-      default: false,
-    },
+export const config = new AdapterConfig({
+  API_ENDPOINT: {
+    description: 'The HTTP URL to retrieve data from',
+    type: 'string',
+    default: 'https://finnhub.io/api/v1',
   },
-  {
-    envDefaultOverrides: {
-      CACHE_MAX_ITEMS: 20000, // stock-quotes return all data in a single call
-    },
+  API_KEY: {
+    description: 'A Finnhub API key ',
+    type: 'string',
+    required: true,
+    sensitive: true,
   },
-)
+  WS_API_ENDPOINT: {
+    description: 'The WS URL to retrieve data from',
+    type: 'string',
+    default: 'wss://ws.finnhub.io',
+  },
+  WS_ENABLED: {
+    description: 'Whether data should be returned from websocket or not',
+    type: 'boolean',
+    default: false,
+  },
+})
 
 // Details that differ depending on which exchange data is being fetched
 // Finnhub separates the Pair symbols by a different character depending on exchange. E.g. "FHFX:EUR-USD" or "OANDA:EUR_USD"

packages/sources/finnhub/src/transport/stock-quotes.ts

@@ -46,49 +46,51 @@ export const httpTransport = new HttpTransport<HttpTransportTypes>({
       })
     }
 
-    return res.data.map((data) => {
-      if (
-        data.a < 0 ||
-        data.av < 0 ||
-        data.b < 0 ||
-        data.bv < 0 ||
-        data.t == 0 ||
-        (data.av == 0 && data.bv == 0)
-      ) {
+    return res.data
+      .filter((d) => params.some((p) => p.base === d.s))
+      .map((data) => {
+        if (
+          data.a < 0 ||
+          data.av < 0 ||
+          data.b < 0 ||
+          data.bv < 0 ||
+          data.t == 0 ||
+          (data.av == 0 && data.bv == 0)
+        ) {
+          return {
+            params: { base: data.s },
+            response: {
+              statusCode: 502,
+              errorMessage: `In-valid data ${JSON.stringify(data)} received for ${data.s}`,
+            },
+          }
+        }
+
+        let midPrice: number
+        if (data.b == 0) {
+          midPrice = data.a
+        } else if (data.a == 0) {
+          midPrice = data.b
+        } else {
+          midPrice = (data.b * data.bv + data.a * data.av) / (data.bv + data.av)
+        }
+
         return {
           params: { base: data.s },
           response: {
-            statusCode: 502,
-            errorMessage: `In-valid data ${JSON.stringify(data)} received for ${data.s}`,
+            result: null,
+            data: {
+              mid_price: midPrice,
+              bid_price: data.b,
+              bid_volume: data.bv,
+              ask_price: data.a,
+              ask_volume: data.av,
+            },
+            timestamps: {
+              providerIndicatedTimeUnixMs: data.t,
+            },
           },
         }
-      }
-
-      let midPrice: number
-      if (data.b == 0) {
-        midPrice = data.a
-      } else if (data.a == 0) {
-        midPrice = data.b
-      } else {
-        midPrice = (data.b * data.bv + data.a * data.av) / (data.bv + data.av)
-      }
-
-      return {
-        params: { base: data.s },
-        response: {
-          result: null,
-          data: {
-            mid_price: midPrice,
-            bid_price: data.b,
-            bid_volume: data.bv,
-            ask_price: data.a,
-            ask_volume: data.av,
-          },
-          timestamps: {
-            providerIndicatedTimeUnixMs: data.t,
-          },
-        },
-      }
-    })
+      })
   },
 })