Skip to content

Commit fd30bbf

Browse files
committed
changed mutable to scalable in help messages.
1 parent d24d844 commit fd30bbf

File tree

5 files changed

+23
-32
lines changed

5 files changed

+23
-32
lines changed

client/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11

2-
# Mutable deployments
2+
# Scalable deployments
33

44

5-
In the case of mutable deployments during a scaling action the following
6-
environment variables are available for the user hook scripts (`OnVmAdd`, `OnVmRemove`,
5+
In the case of scalable deployments during a scaling action the following
6+
environment variables are available for the user hook scripts (`OnVmAdd`, `OnVmRemove`,
77
`Pre-Scale`, `Post-Scale`).
88

99
```
@@ -15,8 +15,8 @@ SLIPSTREAM_SCALING_ACTION # name of the scaling action <vm_resize|disk_attach|di
1515

1616
## Horizontal scalability
1717

18-
If required, the script should be defined in the image module's `OnVmAdd` and/or `OnVmRemove`
19-
targets. `SLIPSTREAM_SCALING_NODE` and `SLIPSTREAM_SCALING_VMS` are intended to be used in
18+
If required, the script should be defined in the image module's `OnVmAdd` and/or `OnVmRemove`
19+
targets. `SLIPSTREAM_SCALING_NODE` and `SLIPSTREAM_SCALING_VMS` are intended to be used in
2020
the following way (`Bash` example).
2121

2222
```bash
@@ -56,9 +56,9 @@ esac
5656

5757
## Vertical and horizontal scalability
5858

59-
If required, the scripts should be defined in the image module's `Pre-Scale` and/or `Post-Scale`
59+
If required, the scripts should be defined in the image module's `Pre-Scale` and/or `Post-Scale`
6060
targets and are intended to be used before and/or after the scaling up/down actions. The scripts
61-
are only executed on the VMs that are subject to the current scaling action. Below are the
61+
are only executed on the VMs that are subject to the current scaling action. Below are the
6262
example scripts for `Bash`.
6363

6464
`Pre-Scale` script. Note that it can be used on VM remove horizontal scalability action.
@@ -67,7 +67,7 @@ example scripts for `Bash`.
6767
#!/bin/bash
6868
set -e
6969

70-
# Pre-scale: intended to be ran before any vertical scaling and horizontal downscaling action.
70+
# Pre-scale: intended to be ran before any vertical scaling and horizontal downscaling action.
7171

7272
function before_vm_remove() { echo "Before VM remove"; }
7373
function before_vm_resize() { echo "Before VM resize"; }
@@ -93,7 +93,7 @@ esac
9393
#!/bin/bash
9494
set -e
9595

96-
# Post-Scale: intended to be ran after vertical scaling action.
96+
# Post-Scale: intended to be ran after vertical scaling action.
9797

9898
function after_vm_resize() { echo "After VM resize"; }
9999
function after_disk_attach() { echo "After disk attach"; }

client/src/main/python/slipstream/command/VerticalScaleCommandBase.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ def _validate_and_set_scale_options(self):
6161

6262
def parse(self):
6363
usage = """%(prog)s %(usage_options)s
64-
<run> Run ID. Run should be mutable and in Ready state.
65-
<node-name> Node name to scale the instances of.
64+
<run> Run ID. Run should be scalable and in Ready state.
65+
<node-name> Node name of the instance to scale.
6666
<ids> IDs of the node instances to scale.""" % {'prog': '%prog',
6767
'usage_options': self._usage_options}
6868

@@ -134,14 +134,14 @@ def _set_run_provisioning(self, client):
134134
client.put(self.run_url + '/ss:state', 'Provisioning')
135135

136136
def _check_allowed_to_scale(self, client):
137-
err_msg = "ERROR: Run should be mutable and in Ready state."
137+
err_msg = "ERROR: Run should be scalable and in Ready state."
138138

139139
ss_state = self._get_ss_state(client)
140140
if 'Ready' != ss_state:
141141
self.usageExit(err_msg + " Run is in %s state." % ss_state)
142142

143-
if not self._is_run_mutable():
144-
self.usageExit(err_msg + " Run is not mutable.")
143+
if not self._is_run_scalable():
144+
self.usageExit(err_msg + " Run is not scalable.")
145145

146146
def _get_ss_state(self, client):
147147
ss_state_url = self.run_url + "/" + NodeDecorator.globalNamespacePrefix + 'state'
@@ -152,6 +152,6 @@ def _retrieve_and_set_run(self, client):
152152
_, run_xml = client.get(self.run_url, 'application/xml')
153153
self.run_dom = etree.fromstring(run_xml)
154154

155-
def _is_run_mutable(self):
156-
mutable = DomExtractor.extract_mutable_from_run(self.run_dom)
157-
return util.str2bool(mutable)
155+
def _is_run_scalable(self):
156+
scalable = DomExtractor.extract_mutable_from_run(self.run_dom)
157+
return util.str2bool(scalable)

client/src/main/python/ss-execute.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,6 @@ def parse(self):
108108
help='Launch a scalable application.',
109109
default=False, action='store_true')
110110

111-
self.parser.add_option('--mutable-run',
112-
dest='scalable',
113-
help='deprecated: use --scalable',
114-
default=False, action='store_true')
115-
116111
self.parser.add_option('--check-ssh-key',
117112
dest='bypass_ssh_check',
118113
help="Check if there is an SSH key in the user profile",

client/src/main/python/ss-node-add.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from slipstream.NodeDecorator import NodeDecorator
2929

3030
class MainProgram(CommandBase):
31-
'''A command-line program to add node instance(s) to a mutable deployment.'''
31+
'''A command-line program to add node instance(s) to a scalable deployment.'''
3232

3333
def __init__(self, argv=None):
3434
self.runId = None
@@ -46,11 +46,9 @@ def __init__(self, argv=None):
4646
def parse(self):
4747
usage = '''usage: %prog [options] <run> <node-name> [<number>]
4848
49-
<run> Run id of the mutable deployment to which to add instance(s).
50-
49+
<run> Run id of the scalable deployment to which to add instance(s).
5150
<node-name> Node name to add instances to.
52-
53-
<number> Number of node instances to add to the mutable deployment run.
51+
<number> Number of node instances to add to the scalable deployment run.
5452
By default, add one.
5553
5654
<number-tolerate> Max number of failed instances to tolerate.

client/src/main/python/ss-node-remove.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import slipstream.commands.NodeInstanceRuntimeParameter as NodeInstanceRuntimeParameter
2828

2929
class MainProgram(CommandBase):
30-
'''A command-line program to remove node instance(s) from a mutable deployment.'''
30+
'''A command-line program to remove node instance(s) from a scalable deployment.'''
3131

3232
def __init__(self, argv=None):
3333
self.runId = None
@@ -43,11 +43,9 @@ def __init__(self, argv=None):
4343
def parse(self):
4444
usage = '''usage: %prog [options] <run> <node-name> <ids> [<ids> ...]
4545
46-
<run> Run id of the mutable deployment from which to remove instance(s).
47-
46+
<run> Run id of the scalable deployment from which to remove instance(s).
4847
<node-name> Node name to remove instances from.
49-
50-
<ids> Ids of the node instances to to remove from a mutable deployment run.'''
48+
<ids> Ids of the node instances to to remove from a scalable deployment run.'''
5149

5250
self.parser.usage = usage
5351
self.add_authentication_options()

0 commit comments

Comments
 (0)