Properly fix stderr test

Author: NigelBreslaw

api/node/__test__/helpers/utils.ts

@@ -0,0 +1,52 @@
+// Copyright © SixtyFPS GmbH <[email protected]>
+// SPDX-License-Identifier: GPL-3.0-only OR LicenseRef-Slint-Royalty-free-2.0 OR LicenseRef-Slint-Software-3.0
+
+import { Console } from "node:console";
+import { Writable } from "node:stream";
+import stripAnsi from "strip-ansi";
+
+export function captureLogs() {
+    const stdout: string[] = [];
+    const stderr: string[] = [];
+
+    const streams = {
+        stdout: new Writable({
+            write(chunk, _encoding, callback) {
+                stdout.push(chunk.toString());
+                callback();
+            },
+        }),
+        stderr: new Writable({
+            write(chunk, _encoding, callback) {
+                stderr.push(chunk.toString());
+                callback();
+            },
+        }),
+    };
+
+    const originalConsole = globalThis.console;
+    globalThis.console = new Console({
+        stdout: streams.stdout,
+        stderr: streams.stderr,
+    });
+
+    const originalStdoutWrite = process.stdout.write;
+    process.stdout.write = streams.stdout.write.bind(streams.stdout) as any;
+
+    const originalStderrWrite = process.stderr.write;
+    process.stderr.write = streams.stderr.write.bind(streams.stderr) as any;
+
+    return {
+        restore() {
+            globalThis.console = originalConsole;
+            process.stdout.write = originalStdoutWrite;
+            process.stderr.write = originalStderrWrite;
+        },
+        getLogs() {
+            return {
+                stdout: stripAnsi(stdout.join("")),
+                stderr: stripAnsi(stderr.join("")),
+            };
+        },
+    };
+}

api/node/__test__/js_value_conversion.spec.mts

@@ -5,8 +5,7 @@ import { test, expect } from "vitest";
 import * as path from "node:path";
 import { fileURLToPath } from "node:url";
 import { Jimp } from "jimp";
-import { captureStderr } from "capture-console";
-
+import { captureLogs } from "./helpers/utils.js";
 import {
     private_api,
     type ImageData,
@@ -1049,7 +1048,7 @@ test("wrong global callback return type ", () => {
     expect(person).toStrictEqual({ name: "", age: 0 });
 });
 
-test("throw exception in callback", () => {
+test("throw exception in callback", async () => {
     const compiler = new private_api.ComponentCompiler();
     const definition = compiler.buildFromSource(
         `
@@ -1069,22 +1068,18 @@ test("throw exception in callback", () => {
         throw new Error("I'm an error");
     });
 
-    const output = captureStderr(() => {
+    const logs = captureLogs();
+    try {
         instance!.invoke("throw-something", []);
-    });
-
-    if (output) {
-        expect(
-            output.includes(
-                "Node.js: Invoking callback 'throw-something' failed",
-            ),
-        ).toBe(true);
-        expect(output.includes("I'm an error")).toBe(true);
-    } else {
-        // If captureStderr doesn't work in Vitest, we at least verify the callback was invoked
-        // The error will be visible in the test output
-        expect(true).toBe(true);
+        await new Promise((resolve) => setTimeout(resolve, 0));
+    } finally {
+        logs.restore();
     }
+    const output = logs.getLogs().stderr;
+    expect(
+        output.includes("Node.js: Invoking callback 'throw-something' failed"),
+    ).toBe(true);
+    expect(output.includes("I'm an error")).toBe(true);
 });
 
 test("throw exception set color", () => {

api/node/package.json

@@ -48,7 +48,7 @@
     "format:fix": "biome format --write",
     "lint": "biome lint",
     "lint:fix": "biome lint --fix",
-    "test": "tsc --build __test__/tsconfig.json && (ava || true) && vitest run"
+    "test": "vitest run"
   },
   "ava": {
     "typescript": {
@@ -75,6 +75,7 @@
     ]
   },
   "dependencies": {
-    "@napi-rs/cli": "2.18.4"
+    "@napi-rs/cli": "2.18.4",
+    "strip-ansi": "7.1.2"
   }
 }