Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

Commit 75fa2cd

Browse files
committed
Update project name, resolve date formatting issue & empty results UI
1 parent f6d3de6 commit 75fa2cd

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+208
-137
lines changed

.github/CONTRIBUTING.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ well.
99
There are many ways you can contribute! :heart:
1010

1111
### Bug Reports and Fixes :bug:
12-
- If you find a bug, please search for it in the [Issues](https://github.com/slackhq/slack-kaldb-app/issues), and if it isn't already tracked,
13-
[create a new issue](https://github.com/slackhq/slack-kaldb-app/issues/new). Fill out the "Bug Report" section of the issue template. Even if an Issue is closed, feel free to comment and add details, it will still
12+
- If you find a bug, please search for it in the [Issues](https://github.com/slackhq/slack-astra-app/issues), and if it isn't already tracked,
13+
[create a new issue](https://github.com/slackhq/slack-astra-app/issues/new). Fill out the "Bug Report" section of the issue template. Even if an Issue is closed, feel free to comment and add details, it will still
1414
be reviewed.
1515
- Issues that have already been identified as a bug (note: able to reproduce) will be labelled `bug`.
1616
- If you'd like to submit a fix for a bug, [send a Pull Request](#creating_a_pull_request) and mention the Issue number.
1717
- Include tests that isolate the bug and verifies that it was fixed.
1818

1919
### New Features :bulb:
20-
- If you'd like to add new functionality to this project, describe the problem you want to solve in a [new Issue](https://github.com/slackhq/slack-kaldb-app/issues/new).
20+
- If you'd like to add new functionality to this project, describe the problem you want to solve in a [new Issue](https://github.com/slackhq/slack-astra-app/issues/new).
2121
- Issues that have been identified as a feature request will be labelled `enhancement`.
2222
- If you'd like to implement the new feature, please wait for feedback from the project
2323
maintainers before spending too much time writing the code. In some cases, `enhancement`s may
@@ -28,7 +28,7 @@ There are many ways you can contribute! :heart:
2828
alternative implementation of something that may have advantages over the way its currently
2929
done, or you have any other change, we would be happy to hear about it!
3030
- If its a trivial change, go ahead and [send a Pull Request](#creating_a_pull_request) with the changes you have in mind.
31-
- If not, [open an Issue](https://github.com/slackhq/slack-kaldb-app/issues/new) to discuss the idea first.
31+
- If not, [open an Issue](https://github.com/slackhq/slack-astra-app/issues/new) to discuss the idea first.
3232

3333
If you're new to our project and looking for some way to make your first contribution, look for
3434
Issues labelled `good first contribution`.
@@ -37,7 +37,7 @@ Issues labelled `good first contribution`.
3737

3838
For your contribution to be accepted:
3939

40-
- [x] You must have signed the [Contributor License Agreement (CLA)](https://cla-assistant.io/slackhq/slack-kaldb-app).
40+
- [x] You must have signed the [Contributor License Agreement (CLA)](https://cla-assistant.io/slackhq/slack-astra-app).
4141
- [x] The test suite must be complete and pass.
4242
- [x] The changes must be approved by code review.
4343
- [x] Commits should be atomic and messages must be descriptive. Related issues should be mentioned by Issue number.
@@ -93,15 +93,15 @@ There are more details about processes and workflow in the [Maintainer's Guide](
9393

9494
#### Proxying
9595
Depending on your setup, it may be advantageous for you to setup a proxy from your
96-
local machine to a KalDB query node running in a cloud environment. Below is
96+
local machine to a Astra query node running in a cloud environment. Below is
9797
an example command to do that (NOTE: this may or may not work depending on
9898
your setup):
9999
```
100100
ssh -N -L $LOCALHOST_PORT:localhost:$REMOTE_PORT $NODE_NAME
101101
```
102102

103103
You would then be able to use `host.docker.internal:$LOCALHOST_PORT` as the
104-
KalDB datasource URL inside your Grafana instance.
104+
Astra datasource URL inside your Grafana instance.
105105

106106

107107
### Backend

.github/ISSUE_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Describe your issue here.
1111
- [ ] discussion
1212

1313
### Requirements (place an `x` in each of the `[ ]`)
14-
* [ ] I've read and understood the [Contributing guidelines](https://github.com/slackhq/slack-kaldb-app/blob/master/.github/contributing.md) and have done my best effort to follow them.
14+
* [ ] I've read and understood the [Contributing guidelines](https://github.com/slackhq/slack-astra-app/blob/master/.github/contributing.md) and have done my best effort to follow them.
1515
* [ ] I've read and agree to the [Code of Conduct](https://slackhq.github.io/code-of-conduct).
1616
* [ ] I've searched for any related issues and avoided creating a duplicate issue.
1717

@@ -23,7 +23,7 @@ Filling out the following details about bugs will help us solve your issue soone
2323

2424
#### Reproducible in:
2525

26-
slack-kaldb-app version:
26+
slack-astra-app version:
2727

2828
Go version:
2929

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Describe the goal of this PR. Mention any related Issue numbers.
44

55
### Requirements (place an `x` in each `[ ]`)
66

7-
* [ ] I've read and understood the [Contributing Guidelines](https://github.com/slackhq/slack-kaldb-app/blob/master/.github/contributing.md) and have done my best effort to follow them.
7+
* [ ] I've read and understood the [Contributing Guidelines](https://github.com/slackhq/slack-astra-app/blob/master/.github/contributing.md) and have done my best effort to follow them.
88
* [ ] I've read and agree to the [Code of Conduct](https://slackhq.github.io/code-of-conduct).
99

1010
> The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)
@@ -13,4 +13,4 @@ Describe the goal of this PR. Mention any related Issue numbers.
1313

1414
> The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io
1515
16-
* [ ] I've read, agree to, and signed the [Contributor License Agreement (CLA)](https://cla-assistant.io/slackhq/slack-kaldb-app).
16+
* [ ] I've read, agree to, and signed the [Contributor License Agreement (CLA)](https://cla-assistant.io/slackhq/slack-astra-app).

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ ci/
2626
e2e-results/
2727

2828
/.idea
29-
/slack-kaldb-app.zip
29+
/slack-astra-app.zip
3030
.DS_Store

CHANGELOG.md

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,18 @@
11
# Changelog
22

3+
## 0.6.0
4+
### New features
5+
* N/A
6+
7+
### Breaking changes
8+
* Project name updated - this will require require re-creating any existing data sources
9+
* Minimum Grafana version updated to 10.0
10+
11+
### Bugs squashed
12+
* Resolved an issue where date time formatting was incorrectly handled after Astra updates to support ES datasources
13+
* Resolved an issue where empty results would incorrectly render faux table contents
14+
* Resolved an issue where empty results would not correctly clear previous result state
15+
316
## 0.5.1
417
### New features
518
* N/A
@@ -112,19 +125,19 @@ N/A
112125
N/A
113126

114127
### Bugs squashed
115-
* Fixed an issue where the KalDB log UI would fail to render in Grafana 9.X versions
116-
* Fixed an issue where we weren't properly mapping and parsing the dates returned by KalDB
128+
* Fixed an issue where the Astra log UI would fail to render in Grafana 9.X versions
129+
* Fixed an issue where we weren't properly mapping and parsing the dates returned by Astra
117130
* Fixed an issue where we still allowed folks to select "PPL" as a query type, despite it not being (currently)
118131
supported
119132

120133
## 0.0.2
121134

122135
### New features
123-
* Initial release of KalDB backend datasource
124-
* Shard count (total, failed) from KalDB explore page
136+
* Initial release of Astra backend datasource
137+
* Shard count (total, failed) from Astra explore page
125138

126139
### Breaking changes
127-
* Elasticsearch is no longer a supported datasource from KalDB explore UI
140+
* Elasticsearch is no longer a supported datasource from Astra explore UI
128141

129142
## 0.0.1
130143

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ To get started [install](https://grafana.com/docs/grafana/latest/plugins/install
1111
the Grafana plugins page under "Astra by Slack". Once installed a new datasource type will be available, and Astra will
1212
appear in the navigation under Apps.
1313

14-
![Astra explore](src/img/kaldb_explore.png)
14+
![Astra explore](src/img/explore.png)
1515

1616
## Other resources
1717
* [Getting started with development](.github/CONTRIBUTING.md#getting-started-with-development)

docker-compose.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@ version: '3.0'
22

33
services:
44
grafana:
5-
container_name: 'slack-kaldb-app'
5+
container_name: 'slack-astra-app'
66
build:
77
context: ./.config
88
args:
99
grafana_version: ${GRAFANA_VERSION:-10.3.1}
1010
ports:
1111
- 3000:3000/tcp
1212
volumes:
13-
- ./dist:/var/lib/grafana/plugins/slack-kaldb-app
13+
- ./dist:/var/lib/grafana/plugins/slack-astra-app
1414
- ./provisioning:/etc/grafana/provisioning
1515
environment:
1616
GF_LOG_MODE: "console file"
@@ -19,5 +19,5 @@ services:
1919
GF_AUTH_ANONYMOUS_ENABLED: "true"
2020
GF_AUTH_ANONYMOUS_ORG_ROLE: "Admin"
2121
GF_PATHS_PLUGINS: "/var/lib/grafana/plugins"
22-
GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS: "slack-kaldb-app,slack-kaldb-app-backend-datasource"
22+
GF_PLUGINS_ALLOW_LOADING_UNSIGNED_PLUGINS: "slack-astra-app,slack-astra-app-backend-datasource"
2323
GF_SERVER_ENABLE_GZIP: "true"

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module github.com/slackhq/slack-kaldb-app
1+
module github.com/slackhq/slack-astra-app
22

33
go 1.14
44

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "slack-kaldb-app",
3-
"version": "0.5.1",
4-
"description": "Grafana KalDB App",
2+
"name": "slack-astra-app",
3+
"version": "0.6.0",
4+
"description": "Grafana Astra App",
55
"scripts": {
66
"build": "webpack -c ./.config/webpack/webpack.config.ts --env production",
77
"build-go": "mage buildAll && mv dist/gpx* dist/datasource",
@@ -16,7 +16,7 @@
1616
"test": "jest --watch --onlyChanged",
1717
"test:ci": "jest --passWithNoTests --maxWorkers 4",
1818
"typecheck": "tsc --noEmit",
19-
"zip": "zip slack-kaldb-app.zip dist/ -rj"
19+
"zip": "zip slack-astra-app.zip dist/ -rj"
2020
},
2121
"author": "Slack",
2222
"license": "Apache-2.0",

pkg/kaldb/kaldb.go renamed to pkg/astra/astra.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package kaldb
1+
package astra
22

33
import (
44
"context"
@@ -8,11 +8,11 @@ import (
88
"github.com/grafana/grafana-plugin-sdk-go/backend/instancemgmt"
99
"github.com/grafana/grafana-plugin-sdk-go/backend/log"
1010
"github.com/grafana/opensearch-datasource/pkg/tsdb"
11-
es "github.com/slackhq/slack-kaldb-app/pkg/kaldb/client"
11+
es "github.com/slackhq/slack-astra-app/pkg/astra/client"
1212
)
1313

14-
// KalDbExecutor represents a handler for handling KalDb datasource request
15-
type KalDbExecutor struct{}
14+
// AstraExecutor represents a handler for handling Astra datasource request
15+
type AstraExecutor struct{}
1616

1717
var (
1818
intervalCalculator tsdb.IntervalCalculator
@@ -22,14 +22,14 @@ type TsdbQueryEndpoint interface {
2222
Query(ctx context.Context, ds *backend.DataSourceInstanceSettings, query *tsdb.TsdbQuery) (*tsdb.Response, error)
2323
}
2424

25-
type KalDbDatasource struct {
25+
type AstraDatasource struct {
2626
dsInfo *backend.DataSourceInstanceSettings
2727
}
2828

29-
func NewKalDbDatasource(settings backend.DataSourceInstanceSettings) (instancemgmt.Instance, error) {
29+
func NewAstraDatasource(settings backend.DataSourceInstanceSettings) (instancemgmt.Instance, error) {
3030
log.DefaultLogger.Debug("Initializing new data source instance")
3131

32-
return &KalDbDatasource{
32+
return &AstraDatasource{
3333
dsInfo: &settings,
3434
}, nil
3535
}
@@ -38,7 +38,7 @@ func NewKalDbDatasource(settings backend.DataSourceInstanceSettings) (instancemg
3838
// The main use case for these health checks is the test button on the
3939
// datasource configuration page which allows users to verify that
4040
// a datasource is working as expected.
41-
func (ds *KalDbDatasource) CheckHealth(ctx context.Context, req *backend.CheckHealthRequest) (*backend.CheckHealthResult, error) {
41+
func (ds *AstraDatasource) CheckHealth(ctx context.Context, req *backend.CheckHealthRequest) (*backend.CheckHealthResult, error) {
4242
res := &backend.CheckHealthResult{}
4343

4444
res.Status = backend.HealthStatusOk
@@ -50,7 +50,7 @@ func (ds *KalDbDatasource) CheckHealth(ctx context.Context, req *backend.CheckHe
5050
// req contains the queries []DataQuery (where each query contains RefID as a unique identifier).
5151
// The QueryDataResponse contains a map of RefID to the response for each query, and each response
5252
// contains Frames ([]*Frame).
53-
func (ds *KalDbDatasource) QueryData(ctx context.Context, req *backend.QueryDataRequest) (*backend.QueryDataResponse, error) {
53+
func (ds *AstraDatasource) QueryData(ctx context.Context, req *backend.QueryDataRequest) (*backend.QueryDataResponse, error) {
5454
if len(req.Queries) == 0 {
5555
return nil, fmt.Errorf("query contains no queries")
5656
}

0 commit comments

Comments
 (0)