Make Quill instances detachable and reconfigurable

packages/quill/src/blots/scroll.ts

@@ -3,6 +3,7 @@ import type { Blot, Parent, EmbedBlot, ParentBlot, Registry } from 'parchment';
 import Delta, { AttributeMap, Op } from 'quill-delta';
 import Emitter from '../core/emitter.js';
 import type { EmitterSource } from '../core/emitter.js';
+import { getSubscriber, Subscriber } from '../core/subscriber.js';
 import Block, { BlockEmbed, bubbleFormats } from './block.js';
 import Break from './break.js';
 import Container from './container.js';
@@ -35,6 +36,7 @@ class Scroll extends ScrollBlot {
   static defaultChild = Block;
   static allowedChildren = [Block, BlockEmbed, Container];
 
+  subscriber: Subscriber;
   emitter: Emitter;
   batch: false | MutationRecord[];
 
@@ -44,11 +46,18 @@ class Scroll extends ScrollBlot {
     { emitter }: { emitter: Emitter },
   ) {
     super(registry, domNode);
+    this.subscriber = getSubscriber(this.domNode);
     this.emitter = emitter;
     this.batch = false;
     this.optimize();
     this.enable();
-    this.domNode.addEventListener('dragstart', (e) => this.handleDragStart(e));
+    const { subscriber } = this;
+    subscriber.on(this, domNode, 'dragstart', (e) => this.handleDragStart(e));
+  }
+
+  detach() {
+    super.detach();
+    this.subscriber.removeSourceListeners(this);
   }
 
   batchStart() {

packages/quill/src/core/composition.ts

@@ -1,6 +1,7 @@
 import Embed from '../blots/embed.js';
 import type Scroll from '../blots/scroll.js';
 import Emitter from './emitter.js';
+import { getSubscriber } from './subscriber.js';
 
 class Composition {
   isComposing = false;
@@ -13,13 +14,14 @@ class Composition {
   }
 
   private setupListeners() {
-    this.scroll.domNode.addEventListener('compositionstart', (event) => {
+    const subscriber = getSubscriber(this.scroll.domNode);
+    subscriber.on(this, this.scroll.domNode, 'compositionstart', (event) => {
       if (!this.isComposing) {
         this.handleCompositionStart(event);
       }
     });
 
-    this.scroll.domNode.addEventListener('compositionend', (event) => {
+    subscriber.on(this, this.scroll.domNode, 'compositionend', (event) => {
       if (this.isComposing) {
         // Webkit makes DOM changes after compositionend, so we use microtask to
         // ensure the order.

packages/quill/src/core/emitter.ts

@@ -67,6 +67,14 @@ class Emitter extends EventEmitter<string> {
     }
     this.domListeners[eventName].push({ node, handler });
   }
+
+  ignoreDOM() {
+    this.domListeners = {};
+  }
+
+  getDomListeners(): Record<string, { node: Node; handler: Function }[]> {
+    return { ...this.domListeners };
+  }
 }
 
 export type EmitterSource =

packages/quill/src/core/quill.ts

@@ -18,6 +18,7 @@ import type { DebugLevel } from './logger.js';
 import Module from './module.js';
 import Selection, { Range } from './selection.js';
 import type { Bounds } from './selection.js';
+import { getSubscriber } from './subscriber.js';
 import Composition from './composition.js';
 import Theme from './theme.js';
 import type { ThemeConstructor } from './theme.js';
@@ -193,22 +194,44 @@ class Quill {
   options: ExpandedQuillOptions;
 
   constructor(container: HTMLElement | string, options: QuillOptions = {}) {
-    this.options = expandConfig(container, options);
-    this.container = this.options.container;
-    if (this.container == null) {
-      debug.error('Invalid Quill container', container);
-      return;
+    this.setup(container, options);
+  }
+
+  configure(options: QuillOptions = {}) {
+    this.setup(this.container, options);
+  }
+
+  detach(): boolean {
+    if (!this.root) {
+      return false;
     }
-    if (this.options.debug) {
-      Quill.debug(this.options.debug);
+
+    const subscriber = getSubscriber(this.root);
+    subscriber.removeAllListeners();
+    this.emitter.removeAllListeners();
+    this.emitter.ignoreDOM();
+    this.scroll.detach();
+    return true;
+  }
+
+  private setup(container: HTMLElement | string, options: QuillOptions) {
+    this.options = expandConfig(container, options);
+    Quill.debug(this.options.debug ?? false);
+    let html = '';
+    if (!this.detach()) {
+      this.container = this.options.container;
+      if (this.container == null) {
+        debug.error('Invalid Quill container', container);
+        return;
+      }
+      html = this.container.innerHTML.trim();
+      this.container.classList.add('ql-container');
+      this.container.innerHTML = '';
+      instances.set(this.container, this);
+      this.root = this.addContainer('ql-editor');
+      this.root.classList.add('ql-blank');
+      this.emitter = new Emitter();
     }
-    const html = this.container.innerHTML.trim();
-    this.container.classList.add('ql-container');
-    this.container.innerHTML = '';
-    instances.set(this.container, this);
-    this.root = this.addContainer('ql-editor');
-    this.root.classList.add('ql-blank');
-    this.emitter = new Emitter();
     const scrollBlotName = Parchment.ScrollBlot.blotName;
     const ScrollBlot = this.options.registry.query(scrollBlotName);
     if (!ScrollBlot || !('blotName' in ScrollBlot)) {
@@ -272,9 +295,13 @@ class Quill {
     this.history.clear();
     if (this.options.placeholder) {
       this.root.setAttribute('data-placeholder', this.options.placeholder);
+    } else {
+      this.root.removeAttribute('data-placeholder');
     }
     if (this.options.readOnly) {
       this.disable();
+    } else {
+      this.enable();
     }
     this.allowReadOnlyEdits = false;
   }

packages/quill/src/core/subscriber.ts

@@ -0,0 +1,131 @@
+import logger from './logger.js';
+
+const debug = logger('quill:subscriber');
+
+/**
+ * Any object with a named constructor can request an event subscription.
+ */
+interface Source {
+  constructor: { name: string };
+}
+
+/**
+ * A subscription to an event listener with an originating object,
+ * an event target, an event type, a handler function for the event,
+ * and some optional configuration.
+ */
+interface Subscription {
+  source: Source;
+  target: EventTarget;
+  event: string;
+  handler: EventListenerOrEventListenerObject;
+  options?: boolean | AddEventListenerOptions;
+}
+
+const subscribers = new WeakMap<object, Subscriber>();
+
+/**
+ * Gets the Subscriber instance bound to the given object.
+ * Creates a new one if the binding does not exist yet.
+ */
+export function getSubscriber(object: Source): Subscriber {
+  let subscriber = subscribers.get(object);
+  if (!subscriber) {
+    debug.info(`Creating new Subscriber for ${object.constructor.name}`);
+    subscriber = new Subscriber();
+    subscribers.set(object, subscriber);
+  }
+  return subscriber;
+}
+
+/**
+ * Keeps track of subscriptions to event listeners,
+ * to enable future bulk unsubscription.
+ */
+class Subscriber {
+  private subscriptions: Subscription[];
+
+  constructor() {
+    this.subscriptions = [];
+  }
+
+  /**
+   * Get a copy of the current subscriptions.
+   */
+  getSubscriptions(): Subscription[] {
+    return [...this.subscriptions];
+  }
+
+  /**
+   * Proxy to target.addEventListener()
+   */
+  on<T extends keyof DocumentEventMap>(
+    source: Source,
+    target: Document,
+    event: T,
+    handler: (ev: DocumentEventMap[T]) => void,
+    options?: boolean | AddEventListenerOptions,
+  ): void;
+  on<T extends keyof HTMLElementEventMap>(
+    source: Source,
+    target: HTMLElement,
+    event: T,
+    handler: (ev: HTMLElementEventMap[T]) => void,
+    options?: boolean | AddEventListenerOptions,
+  ): void;
+  on(
+    source: Source,
+    target: EventTarget,
+    event: string,
+    handler: EventListenerOrEventListenerObject,
+    options?: boolean | AddEventListenerOptions,
+  ) {
+    target.addEventListener(event, handler, options);
+    this.subscriptions.push({ source, target, event, handler, options });
+  }
+
+  /**
+   * Proxy to target.removeEventListener()
+   */
+  off(
+    target: Element,
+    event: string,
+    handler: EventListenerOrEventListenerObject,
+    options?: boolean | AddEventListenerOptions,
+  ) {
+    target.removeEventListener(event, handler, options);
+    this.subscriptions = this.subscriptions.filter(
+      (subscription) =>
+        subscription.target !== target ||
+        subscription.event !== event ||
+        subscription.handler !== handler ||
+        subscription.options !== options,
+    );
+  }
+
+  /**
+   * Remove all event subscriptions originated by the given source.
+   */
+  removeSourceListeners(source: Source) {
+    this.subscriptions
+      .filter((subscription) => subscription.source === source)
+      .forEach(({ target, event, handler, options }) => {
+        target.removeEventListener(event, handler, options);
+      });
+    this.subscriptions = this.subscriptions.filter(
+      (subscription) => subscription.source !== source,
+    );
+  }
+
+  /**
+   * Remove all event subscriptions for all sources.
+   */
+  removeAllListeners() {
+    this.subscriptions.forEach(({ target, event, handler, options }) => {
+      target.removeEventListener(event, handler, options);
+    });
+    this.subscriptions = [];
+  }
+}
+
+export type { Subscriber };

packages/quill/src/formats/list.ts

@@ -1,7 +1,8 @@
 import Block from '../blots/block.js';
 import Container from '../blots/container.js';
-import type Scroll from '../blots/scroll.js';
+import Scroll from '../blots/scroll.js';
 import Quill from '../core/quill.js';
+import { getSubscriber, Subscriber } from '../core/subscriber.js';
 
 class ListContainer extends Container {}
 ListContainer.blotName = 'list-container';
@@ -22,8 +23,11 @@ class ListItem extends Block {
     Quill.register(ListContainer);
   }
 
+  subscriber: Subscriber;
+
   constructor(scroll: Scroll, domNode: HTMLElement) {
     super(scroll, domNode);
+    this.subscriber = getSubscriber(this.scroll.domNode);
     const ui = domNode.ownerDocument.createElement('span');
     const listEventHandler = (e: Event) => {
       if (!scroll.isEnabled()) return;
@@ -36,11 +40,16 @@ class ListItem extends Block {
         e.preventDefault();
       }
     };
-    ui.addEventListener('mousedown', listEventHandler);
-    ui.addEventListener('touchstart', listEventHandler);
+    this.subscriber.on(this, ui, 'mousedown', listEventHandler);
+    this.subscriber.on(this, ui, 'touchstart', listEventHandler);
     this.attachUI(ui);
   }
 
+  detach() {
+    super.detach();
+    this.subscriber.removeSourceListeners(this);
+  }
+
   format(name: string, value: string) {
     if (name === this.statics.blotName && value) {
       this.domNode.setAttribute('data-list', value);

packages/quill/src/modules/clipboard.ts

@@ -14,6 +14,7 @@ import logger from '../core/logger.js';
 import Module from '../core/module.js';
 import Quill from '../core/quill.js';
 import type { Range } from '../core/selection.js';
+import { getSubscriber } from '../core/subscriber.js';
 import { AlignAttribute, AlignStyle } from '../formats/align.js';
 import { BackgroundStyle } from '../formats/background.js';
 import CodeBlock from '../formats/code.js';
@@ -80,11 +81,11 @@ class Clipboard extends Module<ClipboardOptions> {
 
   constructor(quill: Quill, options: Partial<ClipboardOptions>) {
     super(quill, options);
-    this.quill.root.addEventListener('copy', (e) =>
-      this.onCaptureCopy(e, false),
-    );
-    this.quill.root.addEventListener('cut', (e) => this.onCaptureCopy(e, true));
-    this.quill.root.addEventListener('paste', this.onCapturePaste.bind(this));
+    const { root } = this.quill;
+    const subscriber = getSubscriber(root);
+    subscriber.on(this, root, 'copy', (e) => this.onCaptureCopy(e, false));
+    subscriber.on(this, root, 'cut', (e) => this.onCaptureCopy(e, true));
+    subscriber.on(this, root, 'paste', this.onCapturePaste.bind(this));
     this.matchers = [];
     CLIPBOARD_CONFIG.concat(this.options.matchers ?? []).forEach(
       ([selector, matcher]) => {

packages/quill/src/modules/history.ts

@@ -4,6 +4,7 @@ import Module from '../core/module.js';
 import Quill from '../core/quill.js';
 import type Scroll from '../blots/scroll.js';
 import type { Range } from '../core/selection.js';
+import { getSubscriber } from '../core/subscriber.js';
 
 export interface HistoryOptions {
   userOnly: boolean;
@@ -71,7 +72,8 @@ class History extends Module<HistoryOptions> {
       );
     }
 
-    this.quill.root.addEventListener('beforeinput', (event) => {
+    const subscriber = getSubscriber(this.quill.root);
+    subscriber.on(this, this.quill.root, 'beforeinput', (event) => {
       if (event.inputType === 'historyUndo') {
         this.undo();
         event.preventDefault();

packages/quill/src/modules/input.ts

@@ -2,6 +2,7 @@ import Delta from 'quill-delta';
 import Module from '../core/module.js';
 import Quill from '../core/quill.js';
 import type { Range } from '../core/selection.js';
+import { getSubscriber } from '../core/subscriber.js';
 import { deleteRange } from './keyboard.js';
 
 const INSERT_TYPES = ['insertText', 'insertReplacementText'];
@@ -10,7 +11,8 @@ class Input extends Module {
   constructor(quill: Quill, options: Record<string, never>) {
     super(quill, options);
 
-    quill.root.addEventListener('beforeinput', (event) => {
+    const subscriber = getSubscriber(this.quill.root);
+    subscriber.on(this, this.quill.root, 'beforeinput', (event) => {
       this.handleBeforeInput(event);
     });