Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkNatAddress network_id should be integer, not string. #2

Open
etrueskytap opened this issue Jul 18, 2018 · 0 comments
Open

NetworkNatAddress network_id should be integer, not string. #2

etrueskytap opened this issue Jul 18, 2018 · 0 comments

Comments

@etrueskytap
Copy link
Contributor

etrueskytap commented Jul 18, 2018

While mocking up data I discovered a compatibility issue. When a network interface is connected to a NAT network, it has a NAT address which we represent like this:

"nat_addresses": {
  "network_nat_addresses": [
  {
    "ip_address": "10.0.4.1",
    "network_id": 10846630,
    "network_name": "Default Network",
    "network_url": "https://cloud.skytap.com/configurations/18714628/networks/10846630",
    "configuration_id": 18714628,
    "configuration_name": "My Environment",
    "configuration_url": "https://cloud.skytap.com/configurations/18714628",
    "viewable": true
  }
],

The network_id in this data structure is an integer. This is an inconsistency in the REST API -- the network_id of the interface itself is a string. The NetworkNatAddress struct needs to accept an integer when parsing JSON.

ja6a added a commit that referenced this issue Oct 22, 2018
#2 Template datasource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant