Skip to content

Commit 5ec1035

Browse files
author
Armin Schrenk
committed
fix build to output a single archive as artifact
1 parent 85c2d0e commit 5ec1035

File tree

4 files changed

+19
-62
lines changed

4 files changed

+19
-62
lines changed

assembly-linux.xml

+6-21
Original file line numberDiff line numberDiff line change
@@ -4,44 +4,29 @@
44
<id>tarball</id>
55
<includeBaseDirectory>false</includeBaseDirectory>
66
<formats>
7-
<format>zip</format>
7+
<format>tar.gz</format>
88
</formats>
99
<fileSets>
1010
<fileSet>
1111
<directory>target/</directory>
1212
<includes>
13-
<include>version.txt</include>
14-
</includes>
15-
<outputDirectory>libs</outputDirectory>
16-
</fileSet>
17-
<fileSet>
18-
<directory>target/</directory>
19-
<includes>
20-
<include>LICENSE.txt</include>
21-
</includes>
22-
<outputDirectory></outputDirectory>
23-
</fileSet>
24-
<fileSet>
25-
<directory>target/</directory>
26-
<includes>
27-
<include>launcher-linux.sh</include>
13+
<include>helloJavaFX</include>
2814
</includes>
2915
<outputDirectory></outputDirectory>
30-
<fileMode>0755</fileMode>
3116
</fileSet>
3217
<fileSet>
3318
<directory>target/</directory>
3419
<includes>
35-
<include>runtime</include>
20+
<include>LICENSE.txt</include>
3621
</includes>
37-
<outputDirectory></outputDirectory>
22+
<outputDirectory>helloJavaFX</outputDirectory>
3823
</fileSet>
3924
<fileSet>
40-
<directory>target/runtimeImage</directory>
25+
<directory>target/helloJavaFX</directory>
4126
<includes>
4227
<include>**/**</include>
4328
</includes>
44-
<outputDirectory>runtime</outputDirectory>
29+
<outputDirectory>helloJavaFX</outputDirectory>
4530
</fileSet>
4631
</fileSets>
4732
</assembly>

assembly-mac.xml

+5-20
Original file line numberDiff line numberDiff line change
@@ -10,38 +10,23 @@
1010
<fileSet>
1111
<directory>target/</directory>
1212
<includes>
13-
<include>version.txt</include>
14-
</includes>
15-
<outputDirectory>libs</outputDirectory>
16-
</fileSet>
17-
<fileSet>
18-
<directory>target/</directory>
19-
<includes>
20-
<include>LICENSE.txt</include>
21-
</includes>
22-
<outputDirectory></outputDirectory>
23-
</fileSet>
24-
<fileSet>
25-
<directory>target/</directory>
26-
<includes>
27-
<include>launcher-mac.sh</include>
13+
<include>helloJavaFX.app</include>
2814
</includes>
2915
<outputDirectory></outputDirectory>
30-
<fileMode>0755</fileMode>
3116
</fileSet>
3217
<fileSet>
3318
<directory>target/</directory>
3419
<includes>
35-
<include>runtimeImage</include>
20+
<include>LICENSE.txt</include>
3621
</includes>
37-
<outputDirectory></outputDirectory>
22+
<outputDirectory>helloJavaFX.app</outputDirectory>
3823
</fileSet>
3924
<fileSet>
40-
<directory>target/runtimeImage</directory>
25+
<directory>target/helloJavaFX.app</directory>
4126
<includes>
4227
<include>**/**</include>
4328
</includes>
44-
<outputDirectory>runtime</outputDirectory>
29+
<outputDirectory>helloJavaFX.app</outputDirectory>
4530
</fileSet>
4631
</fileSets>
4732
</assembly>

assembly-win.xml

+5-20
Original file line numberDiff line numberDiff line change
@@ -10,38 +10,23 @@
1010
<fileSet>
1111
<directory>target/</directory>
1212
<includes>
13-
<include>version.txt</include>
14-
</includes>
15-
<outputDirectory>libs</outputDirectory>
16-
</fileSet>
17-
<fileSet>
18-
<directory>target/</directory>
19-
<includes>
20-
<include>LICENSE.txt</include>
21-
</includes>
22-
<outputDirectory></outputDirectory>
23-
</fileSet>
24-
<fileSet>
25-
<directory>target/</directory>
26-
<includes>
27-
<include>launcher-win.bat</include>
13+
<include>helloJavaFX</include>
2814
</includes>
2915
<outputDirectory></outputDirectory>
30-
<fileMode>0755</fileMode>
3116
</fileSet>
3217
<fileSet>
3318
<directory>target/</directory>
3419
<includes>
35-
<include>runtime</include>
20+
<include>LICENSE.txt</include>
3621
</includes>
37-
<outputDirectory></outputDirectory>
22+
<outputDirectory>helloJavaFX</outputDirectory>
3823
</fileSet>
3924
<fileSet>
40-
<directory>target/runtimeImage</directory>
25+
<directory>target/helloJavaFX</directory>
4126
<includes>
4227
<include>**/**</include>
4328
</includes>
44-
<outputDirectory>runtime</outputDirectory>
29+
<outputDirectory>helloJavaFX</outputDirectory>
4530
</fileSet>
4631
</fileSets>
4732
</assembly>

pom.xml

+3-1
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,7 @@
147147
<configuration>
148148
<executable>${env.JAVA_HOME}/bin/jpackage</executable>
149149
<workingDirectory>${project.build.directory}</workingDirectory>
150+
<!-- the maven assembly plugin depend on directory name, so be careful when changing it -->
150151
<commandlineArgs>--name helloJavaFX --type app-image -m ${java.jpms.modulename}/${java.jpms.modulename}.App
151152
--runtime-image runtimeImage --app-version ${project.version} --vendor "Skymatic GmbH"
152153
--description "${project.description}" --icon ../skymatic.ico
@@ -196,10 +197,11 @@
196197
</goals>
197198
<configuration>
198199
<descriptors>
200+
<!-- part of the descriptors depend on the jlink output -->
199201
<descriptor>assembly-${assembly.artifact.name}.xml</descriptor>
200202
</descriptors>
201203
<appendAssemblyId>false</appendAssemblyId>
202-
<finalName>javafx-testkit-${assembly.artifact.name}</finalName>
204+
<finalName>helloJavaFX-${project.version}-${assembly.artifact.name}</finalName>
203205
</configuration>
204206
</execution>
205207
</executions>

0 commit comments

Comments
 (0)