Update eslint

Author: hung-phan

.eslintrc

@@ -1,7 +1,7 @@
 {
   "extends": "airbnb",
   "parser": "babel-eslint",
-  "plugins": ["mocha", "babel", "flowtype"],
+  "plugins": ["mocha", "flowtype"],
   "env": {
     "mocha": true,
     "browser": true,
@@ -22,13 +22,7 @@
     "flowtype/space-after-type-colon": [1, "always"],
     "flowtype/space-before-type-colon": [1, "never"],
     "flowtype/type-id-match": [1, "^([A-Z][a-z0-9]+)+Type$"],
-    "flowtype/use-flow-type": 1,
-    "babel/new-cap": 1,
-    "babel/array-bracket-spacing": 1,
-    "babel/object-shorthand": 1,
-    "babel/no-await-in-loop": 1,
-    "babel/flow-object-type": 1,
-    "babel/func-params-comma-dangle": 1
+    "flowtype/use-flow-type": 1
   },
   "settings": {
     "import/resolver": {

package.json

@@ -100,10 +100,10 @@
     "flow:status": "flow status; test $? -eq 0 -o $? -eq 2",
     "flow:stop": "flow stop",
     "flow:watch": "npm run flow:status && chokidar './src/**/*.js' './test/**/*.js' -c 'npm run flow:status'",
+    "lint": "esw -w './src/**/*.js' './test/**/*.js'",
     "prepublish": "npm run build",
     "test": "mocha",
     "test:coverage": "istanbul cover node_modules/mocha/bin/_mocha",
-    "test:lint": "esw -w './src/**/*-test.js' './test/**/*.js'",
     "test:watch": "mocha --watch --reporter progress"
   }
 }

src/csp.operations.js

@@ -390,9 +390,13 @@ const ID_ATTR = '__csp_channel_id';
 function chanId(ch) {
   let id = ch[ID_ATTR];
 
-  if (id === undefined) {
-    id = ch[ID_ATTR] = genId();
+  if (!id) {
+    const generatedId = genId();
+
+    id = generatedId;
+    ch[ID_ATTR] = generatedId;
   }
+
   return id;
 }
 
@@ -584,10 +588,13 @@ class Mix {
       let chanData = this.stateMap[id];
 
       if (!chanData) {
-        chanData = this.stateMap[id] = {
+        const defaultVal = {
           channel: ch,
           state: {},
         };
+
+        chanData = defaultVal;
+        this.stateMap[id] = defaultVal;
       }
       Object.keys(updateState).forEach((mode) => {
         chanData.state[mode] = updateState[mode];
@@ -671,8 +678,12 @@ class Pub {
   _ensureMult(topic) {
     let m = this.mults[topic];
     const bufferFn = this.bufferFn;
+
     if (!m) {
-      m = this.mults[topic] = mult(chan(bufferFn(topic)));
+      const defaultVal = mult(chan(bufferFn(topic)));
+
+      m = defaultVal;
+      this.mults[topic] = defaultVal;
     }
     return m;
   }

src/impl/buffers.js

@@ -1,7 +1,9 @@
 // @flow
-function acopy<T>(src: Array<T>, srcStart: number,
-                  dest: Array<T>, destStart: number,
-                  len: number): void {
+function acopy<T>(
+  src: Array<T>, srcStart: number,
+  dest: Array<T>, destStart: number,
+  len: number,
+): void {
   for (let count = 0; count < len; count += 1) {
     dest[destStart + count] = src[srcStart + count];
   }

src/impl/channels.js

@@ -191,7 +191,6 @@ export class Channel {
     if (this.buf) {
       this.xform['@@transducer/result'](this.buf);
 
-      // flow-ignore
       while (this.buf.count() > 0 && this.takes.length > 0) {
         const taker = this.takes.pop();
 
@@ -240,9 +239,11 @@ function defaultExceptionHandler(err: Error): typeof CLOSED {
   return CLOSED;
 }
 
-function handleEx<T>(buf: BufferType<T>,
-                     exHandler: ?Function,
-                     e: Error): BufferType<T> {
+function handleEx<T>(
+  buf: BufferType<T>,
+  exHandler: ?Function,
+  e: Error,
+): BufferType<T> {
   const def = (exHandler || defaultExceptionHandler)(e);
 
   if (def !== CLOSED) {
@@ -273,9 +274,11 @@ function handleException<T>(exHandler: ?Function): Function {
 
 // XXX: This is inconsistent. We should either call the reducing
 // function xform, or call the transducers xform, not both
-export function chan(buf: ?BufferType<mixed>,
-                     xform: ?Function,
-                     exHandler: ?Function): Channel {
+export function chan(
+  buf: ?BufferType<mixed>,
+  xform: ?Function,
+  exHandler: ?Function,
+): Channel {
   let newXForm: typeof AddTransformer;
 
   if (xform) {

src/impl/select.js

@@ -8,10 +8,10 @@ import { AltHandler } from './handlers';
 import { AltResult, DEFAULT } from './results';
 
 // TODO: Accept a priority function or something
-export function doAlts(
+export function doAlts( // eslint-disable-line
   operations: Channel[] | [Channel, mixed][],
   callback: Function,
-  options: Object
+  options: Object,
 ) {
   if (operations.length === 0) {
     throw new Error('Empty alt list');
@@ -29,13 +29,13 @@ export function doAlts(
     if (operation instanceof Channel) {
       ch = operation;
       result = ch.take(
-        new AltHandler(flag, (value: mixed) => callback(new AltResult(value, ch)))
+        new AltHandler(flag, (value: mixed) => callback(new AltResult(value, ch))),
       );
     } else {
       ch = operation[0];
       result = ch.put(
         operation[1],
-        new AltHandler(flag, (value: mixed) => callback(new AltResult(value, ch)))
+        new AltHandler(flag, (value: mixed) => callback(new AltResult(value, ch))),
       );
     }
 

src/impl/timers.js

@@ -2,7 +2,7 @@
 import { queueDelay } from './dispatch';
 import { chan, Channel } from './channels';
 
-export function timeout(msecs: number): Channel {
+export function timeout(msecs: number): Channel { // eslint-disable-line
   const ch: Channel = chan();
 
   queueDelay(() => ch.close(), msecs);