Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when popen errors due to missing error handling #694

Open
sertonix opened this issue Nov 9, 2024 · 0 comments
Open

Segfault when popen errors due to missing error handling #694

sertonix opened this issue Nov 9, 2024 · 0 comments

Comments

@sertonix
Copy link

sertonix commented Nov 9, 2024

When the popen call in lib/sealcurses/src/video.c#L45 errors it returns NULL. Since there is no error checking the NULL is passed to fgetc and can cause a segfault (at least on musl libc).

(Hope this is enough information to fix the issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant