Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Int" data_type in SimDD.schema? #156

Open
liujin001 opened this issue Aug 2, 2022 · 3 comments · May be fixed by #158
Open

Support "Int" data_type in SimDD.schema? #156

liujin001 opened this issue Aug 2, 2022 · 3 comments · May be fixed by #158

Comments

@liujin001
Copy link

In https://github.com/ska-sa/tango-simlib/blob/master/tango_simlib/utilities/SimDD.schema#L31 , the data_type only support "Boolean", "String", "Double", "VarStringArray", "VarDoubleArray” (For python maybe “Float” is more suitable than "Double"), why not support "Int” type (which can map to tango’s DevShort, DevUShort, DevLong, DevULong, DevLong64, DevULong64 type. etc.) as data types.

Secondly, if we can support "Int" data type, at same time we should add "VarBooleanArray" and "VarIntArray" in data_type enum.

@kmadisa
Copy link
Contributor

kmadisa commented Aug 2, 2022

@liujin001 thanks for submitting another issue. I will have a look at it.

@kmadisa
Copy link
Contributor

kmadisa commented Aug 29, 2022

DevInt is not supported by PyTango:

DevError[
    desc = Attribute : integer:  Data type is not supported
  origin = Attr::check_type
  reason = API_AttrWrongDefined
severity = ERR]
]

kmadisa added a commit that referenced this issue Aug 31, 2022
These updates the SimDD.schema to support more types, especially int types. Note that DevInt is no longer a supported type.
The rest of the changes are to test that we are able to generate a device and read the int type attributes. I have also
updated the tango_sim_generator module to ensure that the  attribute write type defaults to READ if it is not specified
in the config file.

Resolves: #156

Signed-off-by: Katleho Madisa <[email protected]>
kmadisa added a commit that referenced this issue Aug 31, 2022
Resolves: #156

Signed-off-by: Katleho Madisa <[email protected]>
kmadisa added a commit that referenced this issue Aug 31, 2022
Resolves: #156

Signed-off-by: Katleho Madisa <[email protected]>
@kmadisa kmadisa linked a pull request Aug 31, 2022 that will close this issue
5 tasks
@kmadisa
Copy link
Contributor

kmadisa commented Sep 7, 2022

Secondly, if we can support "Int" data type, at same time we should add "VarBooleanArray" and "VarIntArray" in data_type enum.
@liujin001 do you mean you want support for DevEnum types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants