Add .clang-tidy

Author: teqwve

.clang-tidy

@@ -0,0 +1,24 @@
+Checks: '
+  *,
+  -cert-err58-cpp,
+  -cppcoreguidelines-pro-type-union-access,
+  -fuchsia-default-arguments,
+  -fuchsia-overloaded-operator,
+  -fuchsia-statically-constructed-objects,
+  -google-readability-todo,
+  -hicpp-signed-bitwise
+  '
+
+WarningsAsErrors: '
+  clang-analyzer-*,
+  modernize-*,
+  performance-*
+  '
+
+FormatStyle: 'file'
+
+CheckOptions:
+  - key: readability-magic-numbers.IgnoredIntegerValues
+    value: '0;1;2;3;4;16;255;1024'
+  - key: cppcoreguidelines-readability-magic-numbers.IgnoredIntegerValues
+    value: '0;1;2;3;4;16;255;1024'

CMakeLists.txt

@@ -17,6 +17,13 @@ IF(NOT ARCH MATCHES "i386|x86_64|NATIVE")
     MESSAGE(FATAL_ERROR "ARCH should be one of i386, x86_64, NATIVE")
 ENDIF()
 
+IF(NOT DEFINED WITH_CLANG_TIDY)
+    SET(WITH_CLANG_TIDY "NO")
+ENDIF()
+IF(NOT WITH_CLANG_TIDY MATCHES "YES|NO")
+    MESSAGE(FATAL_ERROR "WITH_CLANG_TIDY should be one of YES, NO")
+ENDIF()
+
 INCLUDE(external/libseccomp.cmake)
 INCLUDE(external/libcap.cmake)
 INCLUDE(external/libtclap.cmake)
@@ -47,6 +54,11 @@ ADD_DEFINITIONS('-DBUILD_KERNEL_RELEASE="${BUILD_KERNEL_RELEASE}"')
 
 ENABLE_TESTING()
 
+IF(WITH_CLANG_TIDY STREQUAL "YES")
+    CMAKE_MINIMUM_REQUIRED(VERSION 3.6.3)
+    SET(CMAKE_CXX_CLANG_TIDY clang-tidy)
+ENDIF()
+
 IF(NOT DEFINED WITH_DOCS)
     SET(WITH_DOCS "YES")
 ENDIF()

README.md

@@ -82,3 +82,27 @@ running tests
 To run test suit use 'check' target, e.g in build directory run:
 
     make check
+
+notes for developers
+--------------------
+
+To manually run clang-format on each file run:
+
+    make clang-format
+
+inside build directory.
+
+To manually run clang-tidy on each source file run:
+
+    make clang-tidy
+
+or to use automatically fix errors:
+
+    make clang-tidy-fix
+
+inside build directory.
+
+There is possibility to enable running clang-tidy automatically during
+compilation on each file (can significantly slow down compilation):
+
+    -DWITH_CLANG_TIDY=YES

src/CMakeLists.txt

@@ -11,8 +11,29 @@ INSTALL(TARGETS sio2jail DESTINATION "${CMAKE_INSTALL_FULL_BINDIR}")
 FILE(GLOB_RECURSE all_sources *.cc *.h *.hpp)
 
 ADD_CUSTOM_TARGET(
-  clang-format
-  COMMAND
-    clang-format -style=file -i ${all_sources}
-  WORKING_DIRECTORY
-    ${CMAKE_CURRENT_SOURCE_DIR})
+    clang-format
+    COMMAND
+        clang-format -style=file -i ${all_sources}
+    WORKING_DIRECTORY
+        ${CMAKE_CURRENT_SOURCE_DIR})
+
+SET(clang_tidy_cxx_flags -x;c++;-std=gnu++14)
+
+GET_PROPERTY(include_directories DIRECTORY PROPERTY INCLUDE_DIRECTORIES)
+FOREACH(include_directory IN LISTS include_directories)
+    SET(clang_tidy_cxx_flags ${clang_tidy_cxx_flags};-I${include_directory})
+ENDFOREACH()
+
+ADD_CUSTOM_TARGET(
+    clang-tidy
+    COMMAND
+        clang-tidy ${sources} -- ${clang_tidy_cxx_flags}
+    WORKING_DIRECTORY
+        ${CMAKE_CURRENT_SOURCE_DIR})
+
+ADD_CUSTOM_TARGET(
+    clang-tidy-fix
+    COMMAND
+        clang-tidy ${sources} -fix -fix-errors -- ${clang_tidy_cxx_flags}
+    WORKING_DIRECTORY
+        ${CMAKE_CURRENT_SOURCE_DIR})