Skip to content

Add Support for Symfony 8 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeahAuroraV wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −16
Open

Add Support for Symfony 8 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01088bb
Add Support for Symfony 8
Leah-BW Jan 22, 2026
197cf56
Fix Tests
Leah-BW Jan 22, 2026
ae3f154
Fix Tests
Leah-BW Jan 23, 2026
c620213
Fix Tests
Leah-BW Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/code_style_and_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,15 @@ jobs:
continue-on-error: true
strategy:
matrix:
php: ['7.3', '8.1', '8.2', '8.3']
symfony: ['~5.0', '~6.0', '~7.0']
php: ['8.2', '8.3', '8.4', '8.5']
Copy link

@thePanz thePanz Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep the 7.4 version as in composer.json the min PHP version is set to 7.3?

... maybe it's time to remove that unmaintained version too :)

symfony: ['^6.4', '^7.0', '^8.0']
dependencies:
- 'highest'
exclude:
- php: '7.3'
symfony: '~6.0'
- php: '7.3'
symfony: '~7.0'
- php: '8.1'
symfony: '~7.0'
- php: '8.2'
symfony: '^8.0'
- php: '8.3'
symfony: '^8.0'
fail-fast: false
steps:
- name: 'Start ClamAV daemon (clamd)'
Expand Down
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
],
"require": {
"php": "^7.3 || ^8.0",
"symfony/http-kernel": "~4.0 || ~5.0 || ~6.0 || ~7.0",
"symfony/config": "~4.0 || ~5.0 || ~6.0 || ~7.0",
"symfony/dependency-injection": "~4.0 || ~5.0 || ~6.0 || ~7.0",
"symfony/yaml": "~4.0 || ~5.0 || ~6.0 || ~7.0",
"symfony/http-kernel": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/config": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/dependency-injection": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"symfony/yaml": "^5.4 || ^6.4 || ^7.0 || ^8.0",
"ext-sockets": "*"
},
"require-dev": {
Expand Down
2 changes: 1 addition & 1 deletion src/Bundle/DependencyInjection/SineflowClamAVExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class SineflowClamAVExtension extends Extension
{
public function load(array $configs, ContainerBuilder $container)
public function load(array $configs, ContainerBuilder $container): void
{
$configuration = new Configuration();
$config = $this->processConfiguration($configuration, $configs);
Expand Down
2 changes: 1 addition & 1 deletion tests/Functional/BundleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ public function registerBundles(): iterable
new SineflowClamAVBundle(),
];
}
public function registerContainerConfiguration(LoaderInterface $loader)
public function registerContainerConfiguration(LoaderInterface $loader): void
{
}
}
Expand Down
4 changes: 2 additions & 2 deletions tests/Functional/ScannerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ public function validFilesToCheckProvider()
{
return [
[realpath(__DIR__.'/../Files/clean.txt'), false, ''],
[realpath(__DIR__.'/../Files/eicar.txt'), true, 'Win.Test.EICAR_HDB-1'],
[realpath(__DIR__.'/../Files/eicar.txt'), true, 'Eicar-Test-Signature'],
[realpath(__DIR__.'/../Files/eicar-dropper.pdf'), true, 'Pdf.Dropper.Agent-6299400-0'],
[realpath(__DIR__.'/../Files/infected-archive.zip'), true, 'Win.Test.EICAR_HDB-1'],
[realpath(__DIR__.'/../Files/infected-archive.zip'), true, 'Eicar-Test-Signature'],
];
}

Expand Down