prefer-math-min-max issue with luxon objects

[eldair]

Prefer math min max should not be reported for luxon objects because Math.min/max returns timestamp instead of original object which causes errors if not corrected and also there is loss of other information if object is recreated from Math result (like timezone)

prefer-math-min-max

let start = DateTime.local().startOf('day').minus({days: 5});
let end = DateTime.local().startOf('day').minus({days: 1});

let min = Math.min(start, end);
// min is now a timestamp and not an object.

[axetroy]

Since there is no Type-aware in the Plugin, we cannot know its type

This seems normal to me, using implicit valueOf() is not the recommended way

let start = DateTime.local().startOf('day').minus({days: 5});
let end = DateTime.local().startOf('day').minus({days: 1});

// ❌ implicit `valueOf()`
let min = start > end ? end : start;

You should write to this

let start = DateTime.local().startOf('day').minus({days: 5});
let end = DateTime.local().startOf('day').minus({days: 1});

// ✅
let min = start.valueOf() > end.valueOf() ? end : start;

[eldair]

@axetroy thanks for getting back to me.
I actually like your suggestion but that line will not report I have used implicit valueOf, only math errors.

Maybe autofix should be turned off for anything except numbers to Math.min/max, the way it works seems unsafe.

[eldair]

If disabling auto fix for non numbers is something you would consider I could make a pull request