You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Tests use CliRunner.isolated_filesystem(), which is deprecated and will be removed in Click 9.0 #916
Running the test suite produces 33 DeprecationWarnings from Click:
DeprecationWarning: 'isolated_filesystem' is deprecated and will be removed in Click 9.0. Use 'tempfile.TemporaryDirectory' or pytest's 'tmp_path' fixture with absolute paths instead.
Once Click 9.0 is released, these tests will fail, since sqlite-utils doesn't pin Click below 9.
Steps to reproduce
git clone https://github.com/simonw/sqlite-utils
cd sqlite-utils
uv run pytest
Expected
Test suite passes with no deprecation warnings from the project's own tests.
Actual
1497 passed, 16 skipped, 33 warnings — all 33 warnings are the isolated_filesystem deprecation.
Affected code
22 with runner.isolated_filesystem(): calls (33 test runs once parametrization is counted):
Find them with: grep -n isolated_filesystem tests/*.py
Suggested fix
Replace runner.isolated_filesystem() with pytest's tmp_path fixture (or monkeypatch.chdir(tmp_path) where tests rely on relative paths), as the warning recommends.
Activity