|
27 | 27 | {"types": {"age": int}}, |
28 | 28 | [ |
29 | 29 | 'CREATE TABLE "dogs_new_suffix" (\n "id" INTEGER PRIMARY KEY,\n "name" TEXT,\n "age" INTEGER\n);', |
30 | | - 'INSERT INTO "dogs_new_suffix" ("rowid", "id", "name", "age")\n SELECT "rowid", "id", "name", "age" FROM "dogs";', |
| 30 | + 'INSERT INTO "dogs_new_suffix" ("rowid", "id", "name", "age")\n SELECT "rowid", "id", "name", NULLIF("age", \'\') FROM "dogs";', |
31 | 31 | 'DROP TABLE "dogs";', |
32 | 32 | "PRAGMA legacy_alter_table=ON;", |
33 | 33 | 'ALTER TABLE "dogs_new_suffix" RENAME TO "dogs";', |
|
63 | 63 | {"types": {"age": int}, "rename": {"age": "dog_age"}}, |
64 | 64 | [ |
65 | 65 | 'CREATE TABLE "dogs_new_suffix" (\n "id" INTEGER PRIMARY KEY,\n "name" TEXT,\n "dog_age" INTEGER\n);', |
66 | | - 'INSERT INTO "dogs_new_suffix" ("rowid", "id", "name", "dog_age")\n SELECT "rowid", "id", "name", "age" FROM "dogs";', |
| 66 | + 'INSERT INTO "dogs_new_suffix" ("rowid", "id", "name", "dog_age")\n SELECT "rowid", "id", "name", NULLIF("age", \'\') FROM "dogs";', |
67 | 67 | 'DROP TABLE "dogs";', |
68 | 68 | "PRAGMA legacy_alter_table=ON;", |
69 | 69 | 'ALTER TABLE "dogs_new_suffix" RENAME TO "dogs";', |
@@ -168,7 +168,7 @@ def tracer(sql, params): |
168 | 168 | {"types": {"age": int}}, |
169 | 169 | [ |
170 | 170 | 'CREATE TABLE "dogs_new_suffix" (\n "id" INTEGER,\n "name" TEXT,\n "age" INTEGER\n);', |
171 | | - 'INSERT INTO "dogs_new_suffix" ("rowid", "id", "name", "age")\n SELECT "rowid", "id", "name", "age" FROM "dogs";', |
| 171 | + 'INSERT INTO "dogs_new_suffix" ("rowid", "id", "name", "age")\n SELECT "rowid", "id", "name", NULLIF("age", \'\') FROM "dogs";', |
172 | 172 | 'DROP TABLE "dogs";', |
173 | 173 | "PRAGMA legacy_alter_table=ON;", |
174 | 174 | 'ALTER TABLE "dogs_new_suffix" RENAME TO "dogs";', |
@@ -1125,6 +1125,36 @@ def test_transform_preserves_autoincrement_and_sequence(fresh_db): |
1125 | 1125 | ] |
1126 | 1126 |
|
1127 | 1127 |
|
| 1128 | +@pytest.mark.parametrize( |
| 1129 | + "new_type,expected_value,expected_type", |
| 1130 | + [ |
| 1131 | + (int, 42, int), |
| 1132 | + (float, 42.0, float), |
| 1133 | + ("integer", 42, int), |
| 1134 | + ("float", 42.0, float), |
| 1135 | + ("REAL", 42.0, float), |
| 1136 | + ], |
| 1137 | +) |
| 1138 | +def test_transform_empty_string_to_null_for_numeric_types( |
| 1139 | + fresh_db, new_type, expected_value, expected_type |
| 1140 | +): |
| 1141 | + fresh_db["test"].insert_all( |
| 1142 | + [ |
| 1143 | + {"id": 1, "value": "42"}, |
| 1144 | + {"id": 2, "value": ""}, |
| 1145 | + {"id": 3, "value": None}, |
| 1146 | + {"id": 4, "value": " "}, |
| 1147 | + ] |
| 1148 | + ) |
| 1149 | + fresh_db["test"].transform(types={"value": new_type}) |
| 1150 | + rows = {r["id"]: r["value"] for r in fresh_db["test"].rows} |
| 1151 | + assert rows[1] == expected_value |
| 1152 | + assert type(rows[1]) is expected_type |
| 1153 | + assert rows[2] is None |
| 1154 | + assert rows[3] is None |
| 1155 | + assert rows[4] == " " |
| 1156 | + |
| 1157 | + |
1128 | 1158 | def test_transform_preserves_view(fresh_db): |
1129 | 1159 | # https://github.com/simonw/sqlite-utils/issues/831 |
1130 | 1160 | dogs = fresh_db.table("dogs") |
|
0 commit comments