Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strings before auto correction #14

Open
HolgerJeromin opened this issue Jul 20, 2017 · 2 comments
Open

Remove strings before auto correction #14

HolgerJeromin opened this issue Jul 20, 2017 · 2 comments
Labels
enhancement

Comments

@HolgerJeromin
Copy link

When I remove "uhr" from the homepage string the auto correction transforms it to a valid definition
"Mo-Fr 7-18 Uhr, Sa 7-18 Uhr, So 7-18 Uhr"
@simonpoole
Copy link
Owner

That works because you are a human (I think :-)). The parser could likely be more aggressive in skipping invalid input and restarting instead of failing, but that doesn't necessarily mean that overall parsing performance would really improve, just that "something" would be returned even if it is total nonsense.

@simonpoole simonpoole mentioned this issue Jul 20, 2017
Open
10 tasks
@ypid ypid mentioned this issue Jul 20, 2017
Closed
@simonpoole
Copy link
Owner

See simonpoole/OpeningHoursParser#11 for the upstream issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonpoole @HolgerJeromin