Repository navigation
fix: patch four correctness bugs found in state/plugin/API layer - #521
noahzuerii wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Thanks for this - a careful read of the state and API layers, and two of these are bugs I am glad to have found.
|
…ased on main) - PluginManager: fix a race where disabling a layer while enablePlugin() was still resolving its awaits could restart polling and re-emit layerToggled(true), leaking a background fetch loop and a stale websocket subscription for a layer the UI showed as disabled. Fixed with a per-plugin toggle epoch that lets an in-flight enablePlugin detect it was superseded by a later toggle. - data-query service / region API route: clamp `limit` with a lower bound of 1 (matching searchEntities' existing clamp), so a negative limit can no longer produce a negative Array.slice bound and return an incorrect entity set. - favoritesSlice: revert the optimistic add/remove on a failed POST/DELETE and surface an error toast, following the same optimistic-flip-with-rollback pattern already used in alertsSlice. - dataSlice.getAllEntities: filter by the layer's enabled flag to match its own docstring and PluginManager.getAllEntities' semantics. Fix: chore/refactor+fix mix -> patch bump per project convention. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FyQHTVUZs5PzRkYJa7Tq4h
f935148 to
c6480b0
Compare
|
Left for a person rather than auto-merged: not a Dependabot pull request. Patch and minor updates merge themselves once every check has completed green; this one is listed in the weekly dependency digest. |
limitwith a lower bound of 1 (matching searchEntities' existing clamp), so a negative limit can no longer produce a negative Array.slice bound and return an incorrect entity set.Fix: chore/refactor+fix mix -> patch bump per project convention.
Type of Change