Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some instructions not disassembling in Ghidra. #1

Open
Fishybob opened this issue Feb 7, 2023 · 4 comments
Open

Some instructions not disassembling in Ghidra. #1

Fishybob opened this issue Feb 7, 2023 · 4 comments

Comments

@Fishybob
Copy link

Fishybob commented Feb 7, 2023

Hi Chris, Thanks for making your M16c Ghidra support available on Github. I am working with some R8c/36 processors (cost reduced M16c) and noticed that a few MUL/MULU instructions are not disassembled in Ghidra.
The problematic instruction encodings I have seen are:

  • 79B0FD "MUL.W -3H[FB],R0"
  • 7D4BF6FF8F "MULU.W #8FFFH,-AH[FB]"
  • 7D4BFCB45F "MULU.W #5FB4H, -4H[FB]"
    (The disassembly is from the Renesas HEW tools.)

...Ah, I see your "TODO" notes in m16c.slaspec for MUL.W/MULU.W destinations so I guess this is a known issue...
Thanks again for making you work available!

@silverchris
Copy link
Owner

Ya, I haven't figured out the best way to handle them yet. Think I am just going to do it the simplest way, which might happen this weekend.

Also, I am happy this is somewhat useful, I wasn't sure if anyone else would find it so. I am sure there are other bugs hiding, as I have only been using it on one program really, myself

@esaulenka
Copy link

Also, I am happy this is somewhat useful, I wasn't sure if anyone else would find it so

Chris, thanks a lot for this project. I am digging into some ancient vehicle brain, and your work is VERY useful for me. Thanks again.

@esaulenka
Copy link

@Fishybob, if you are still working with this stuff, try also my fork of this repo. I have improved it a bit.

@silverchris, I'll be glad if you find some time to merge back my changes in your branch.

@Fishybob
Copy link
Author

@esaulenka, thanks for making your enhancements available. (I setup the Eclipse environment last month and tried to clean up MULx.W but the sleigh spec was melting my brain... ;-)

RyanHope pushed a commit to RyanHope/m16c that referenced this issue Jun 1, 2024
RyanHope pushed a commit to RyanHope/m16c that referenced this issue Jun 1, 2024
Pull improvements from Alexey's fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants