Skip to content

Conversation

@Nateowami
Copy link
Collaborator

@Nateowami Nateowami commented Dec 3, 2025

Also simplified the logic


This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.82%. Comparing base (813f7dc) to head (3f97f3b).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3601      +/-   ##
==========================================
- Coverage   82.82%   82.82%   -0.01%     
==========================================
  Files         610      609       -1     
  Lines       37216    37204      -12     
  Branches     6077     6095      +18     
==========================================
- Hits        30824    30813      -11     
+ Misses       5477     5464      -13     
- Partials      915      927      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami force-pushed the feature/SF-3609-use-CanDenormalizeQuotes-flag branch from 8aa227e to de4c4d0 Compare December 3, 2025 22:14
@Nateowami Nateowami force-pushed the feature/SF-3609-use-CanDenormalizeQuotes-flag branch from de4c4d0 to 3f97f3b Compare December 4, 2025 00:28
@RaymondLuong3 RaymondLuong3 self-assigned this Dec 4, 2025
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to make user of the new data model from serval!

@RaymondLuong3 reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Nateowami)


src/SIL.XForge.Scripture/ClientApp/src/app/translate/draft-generation/draft-usfm-format/draft-usfm-format.component.ts line 124 at r1 (raw file):

  get showQuoteFormatWarning(): boolean {
    return this.canDenormalizeQuotes === false;

Making this change means that old clients are not compatible. Old clients will always show denormalization is not possible. I think this is OK since there will be a banner notifying the user that an update is available. Just mentioning it here so it doesn't get missed.

Code quote:

  get showQuoteFormatWarning(): boolean {
    return this.canDenormalizeQuotes === false;

@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants