Assume default model dir if train is not present (#814)

Author: TaperChipmunk32

silnlp/nmt/experiment.py

@@ -80,7 +80,7 @@ def test(self):
             scorers=self.scorers,
             produce_multiple_translations=self.produce_multiple_translations,
             save_confidences=self.save_confidences,
-            save_checkpoints=self.save_checkpoints,
+            use_default_model_dir=self.save_checkpoints,
         )
 
     def translate(self):
@@ -94,7 +94,7 @@ def translate(self):
             translator = TranslationTask(
                 name=self.name,
                 checkpoint=config.get("checkpoint", "last"),
-                use_default_model_dir=True if not (self.run_train) else self.save_checkpoints,
+                use_default_model_dir=self.save_checkpoints,
                 commit=self.commit,
             )
 
@@ -155,7 +155,12 @@ def main() -> None:
         help="Run remotely on ClearML queue.  Default: None - don't register with ClearML.  The queue 'local' will run "
         + "it locally and register it with ClearML.",
     )
-    parser.add_argument("--save-checkpoints", default=False, action="store_true", help="Save checkpoints to S3 bucket")
+    parser.add_argument(
+        "--save-checkpoints",
+        default=False,
+        action="store_true",
+        help="Save checkpoints to bucket. Only used if running the train step.",
+    )
     parser.add_argument("--preprocess", default=False, action="store_true", help="Run the preprocess step.")
     parser.add_argument("--train", default=False, action="store_true", help="Run the train step.")
     parser.add_argument("--test", default=False, action="store_true", help="Run the test step.")
@@ -206,6 +211,9 @@ def main() -> None:
         args.train = True
         args.test = True
 
+    if not args.train:
+        args.save_checkpoints = True
+
     exp = SILExperiment(
         name=args.experiment,
         make_stats=args.stats,

silnlp/nmt/test.py

@@ -592,10 +592,10 @@ def test(
     by_book: bool = False,
     produce_multiple_translations: bool = False,
     save_confidences: bool = False,
-    save_checkpoints: bool = False,
+    use_default_model_dir: bool = False,
 ):
     exp_name = experiment
-    config = load_config(exp_name, save_checkpoints)
+    config = load_config(exp_name, use_default_model_dir)
 
     if not any(config.exp_dir.glob("test*.src.txt")):
         LOGGER.info("No test dataset.")