-
Notifications
You must be signed in to change notification settings - Fork 63
Bump sigstore/cosign-installer from 3.10.0 to 4.0.0 #1766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dependabot
wants to merge
6
commits into
main
Choose a base branch
from
dependabot/github_actions/sigstore/cosign-installer-4.0.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4782a02
Bump sigstore/cosign-installer from 3.10.0 to 4.0.0
dependabot[bot] c6218e0
workflows: Update cosign use in fulcio-rekor-kind
jku 91a6b40
workflows: Update test-action-tuf for new cosign
jku 95732b2
workflows: Modify add-remove-new-fulcio for new cosign
jku 60770f2
workflows: Make test-release comtpaible with cosign 4
jku 9658a98
workflows: Update test-setup-sigstore-env for cosign 4
jku File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,36 +17,38 @@ jobs: | |
| persist-credentials: false | ||
| - id: setup-sigstore-env | ||
| uses: ./actions/setup-sigstore-env | ||
| - uses: sigstore/cosign-installer@d7543c93d881b35a8faa02e8e3605f69b7a1ce62 # v3.10.0 | ||
| - uses: sigstore/cosign-installer@faadad0cce49287aee09b3a48701e75088a2c6ad # v4.0.0 | ||
| with: | ||
| cosign-release: main | ||
| - name: Create artifact to sign | ||
| run: head -c 128 < /dev/urandom > artifact | ||
| - name: Run cosign sign-blob | ||
| env: | ||
| SIGSTORE_CT_LOG_PUBLIC_KEY_FILE: ${{ steps.setup-sigstore-env.outputs.ct-log-key }} | ||
| STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_OIDC_URL: ${{ steps.setup-sigstore-env.outputs.oidc-url }} | ||
| STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_OIDC_TOKEN: ${{ steps.setup-sigstore-env.outputs.oidc-token }} | ||
| OIDC_URL: ${{ steps.setup-sigstore-env.outputs.oidc-url }} | ||
| OIDC_TOKEN: ${{ steps.setup-sigstore-env.outputs.oidc-token }} | ||
| TRUSTED_ROOT: ${{ steps.setup-sigstore-env.outputs.trusted-root }} | ||
| SIGNING_CONFIG: ${{ steps.setup-sigstore-env.outputs.signing-config }} | ||
| run: | | ||
| echo token: | ||
| curl -f ${STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_OIDC_URL}/token | ||
| curl -f ${OIDC_URL}/token | ||
| cosign sign-blob \ | ||
| -y \ | ||
| --bundle=bundle.json \ | ||
| --new-bundle-format=true \ | ||
| --rekor-url http://localhost:3000 \ | ||
| --fulcio-url http://localhost:5555 \ | ||
| --identity-token ${STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_OIDC_TOKEN} \ | ||
| --trusted-root ${TRUSTED_ROOT} \ | ||
| --signing-config ${SIGNING_CONFIG} \ | ||
| --identity-token ${OIDC_TOKEN} \ | ||
| artifact | ||
| - name: Run cosign verify-blob with trusted root | ||
| run: | | ||
| cosign verify-blob \ | ||
| --trusted-root ${STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_TRUSTED_ROOT} \ | ||
| --trusted-root ${TRUSTED_ROOT} \ | ||
| --bundle bundle.json \ | ||
| --new-bundle-format=true \ | ||
| --certificate-identity [email protected] \ | ||
| --certificate-oidc-issuer ${STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_ISSUER_URL} \ | ||
| --certificate-oidc-issuer ${ISSUER_URL} \ | ||
| artifact | ||
| env: | ||
| STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_TRUSTED_ROOT: ${{ steps.setup-sigstore-env.outputs.trusted-root }} | ||
| STEPS_SETUP_SIGSTORE_ENV_OUTPUTS_ISSUER_URL: ${{ steps.setup-sigstore-env.outputs.issuer-url }} | ||
| TRUSTED_ROOT: ${{ steps.setup-sigstore-env.outputs.trusted-root }} | ||
| ISSUER_URL: ${{ steps.setup-sigstore-env.outputs.issuer-url }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not completely obvious to me that we're using the on-cluster versions of these services in this PR (looks like we might be reverting to PGI, which would not be what we'd want)?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a
earlier in the workflow which I believe should handle this -- but I agree the order of these steps seems strange (and the cosign UX design is dangerous: using a non-default instance should always be obvious).
I may have to rethink this altogether because the on-cluster tuf repo is missing the signingconfig file