MAG-769: Minor fixes to SDK

Author: ebanolopes

composer.json

@@ -2,7 +2,7 @@
   "name": "signifyd/signifyd-php",
   "description": "Signifyd client API plugin for PHP",
   "type": "library",
-  "version": "4.0.1",
+  "version": "4.0.2",
   "license": [
     "MIT"
   ],

lib/Core/Response.php

@@ -24,6 +24,13 @@
  */
 abstract class Response
 {
+    /**
+     * Messages describing the error.
+     *
+     * @var array
+     */
+    public $messages = [];
+
     /**
      * Response constructor.
      *
@@ -93,24 +100,48 @@ public function setErrorMessage($errorMessage)
     }
 
     /**
-     * Get if there is an error
+     * Setting the response data
      *
-     * @return bool
+     * @param string $response The response from Signifyd
+     *
+     * @return void
      */
-    public function isError()
+    public function setObject($response)
     {
-      return $this->isError;
+
     }
 
     /**
-     * Setting the response data
+     * Setting the message
      *
-     * @param string $response The response from Signifyd
+     * @param string $message
      *
      * @return void
      */
-    public function setObject($response)
+    public function addMessage($message)
+    {
+        $this->messages[] = $message;
+    }
+
+    /**
+     * Retrieve all messages
+     *
+     * @return array
+     */
+    public function getMessages()
     {
+        return $this->messages;
+    }
 
+    /**
+     * Set messages
+     *
+     * @param array $messages
+     *
+     * @return void
+     */
+    public function setMessages($messages)
+    {
+        $this->messages = $messages;
     }
 }

lib/Core/Response/CaseResponse.php

@@ -212,8 +212,6 @@ class CaseResponse extends Response
 
     public $recommendedAction;
 
-    public $message = [];
-
     public $isTest;
 
     public $customerCaseId;

lib/Core/Response/CheckoutsResponse.php

@@ -66,13 +66,6 @@ class CheckoutsResponse extends Response
      */
     public $scaEvaluation;
 
-    /**
-     * Messages describing the error.
-     *
-     * @var array of string
-     */
-    public $messages = [];
-
     /**
      * If there is an error and you would like to contact Signifyd,
      * please include this id in your support request.
@@ -277,21 +270,6 @@ public function setCoverage($coverage)
         $this->coverage = $coverage;
     }
 
-    public function getMessages()
-    {
-        return $this->messages;
-    }
-
-    public function setMessages($messages)
-    {
-        $this->messages = $messages;
-    }
-
-    public function addMessage($message)
-    {
-        $this->messages[] = $message;
-    }
-
     public function getTraceId()
     {
         return $this->traceId;

lib/Core/Response/ReroutesResponse.php

@@ -58,13 +58,6 @@ class ReroutesResponse extends Response
      */
     public $coverage;
 
-    /**
-     * Messages describing the error.
-     *
-     * @var array of string
-     */
-    public $messages = [];
-
     /**
      * If there is an error and you would like to contact Signifyd,
      * please include this id in your support request.
@@ -245,21 +238,6 @@ public function setCoverage($coverage)
         $this->coverage = $coverage;
     }
 
-    public function getMessages()
-    {
-        return $this->messages;
-    }
-
-    public function setMessages($messages)
-    {
-        $this->messages = $messages;
-    }
-
-    public function addMessage($message)
-    {
-        $this->messages[] = $message;
-    }
-
     public function getTraceId()
     {
         return $this->traceId;

lib/Core/Response/SaleResponse.php

@@ -49,13 +49,6 @@ class SaleResponse extends Response
      */
     public $coverage;
 
-    /**
-     * Messages describing the error.
-     *
-     * @var array of string
-     */
-    public $messages = [];
-
     /**
      * If there is an error and you would like to contact Signifyd,
      * please include this id in your support request.
@@ -224,21 +217,6 @@ public function setCoverage($coverage)
         $this->coverage = $coverage;
     }
 
-    public function getMessages()
-    {
-        return $this->messages;
-    }
-
-    public function setMessages($messages)
-    {
-        $this->messages = $messages;
-    }
-
-    public function addMessage($message)
-    {
-        $this->messages[] = $message;
-    }
-
     public function getTraceId()
     {
         return $this->traceId;

lib/Core/Response/TransactionsResponse.php

@@ -24,8 +24,6 @@ class TransactionsResponse extends Response
      */
     public $transactions;
 
-    public $message = [];
-
     public function __construct($logger)
     {
         if (!is_object($logger) || get_class($logger) !== 'Signifyd\Core\Logging') {

lib/Core/Response/WebhooksBulkResponse.php

@@ -50,8 +50,6 @@ class WebhooksBulkResponse extends Response
      */
     public $errorMessage;
 
-    public $message = [];
-
     /**
      * The logger object
      *

lib/Core/Response/WebhooksResponse.php

@@ -77,10 +77,11 @@ class WebhooksResponse extends Response
      */
     public $errorMessage;
 
+    /**
+     * @var array
+     */
     public $responseArray = [];
 
-    public $message = [];
-
     /**
      * The logging object
      *